From owner-freebsd-hackers  Tue Mar 11 00:43:00 1997
Return-Path: <owner-hackers>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id AAA06739
          for hackers-outgoing; Tue, 11 Mar 1997 00:43:00 -0800 (PST)
Received: from cheops.anu.edu.au (avalon@cheops.anu.edu.au [150.203.76.24])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id AAA06723
          for <hackers@freebsd.org>; Tue, 11 Mar 1997 00:42:57 -0800 (PST)
Message-Id: <199703110842.AAA06723@freefall.freebsd.org>
Received: by cheops.anu.edu.au
	(1.37.109.16/16.2) id AA107339550; Tue, 11 Mar 1997 19:39:10 +1100
From: Darren Reed <avalon@coombs.anu.edu.au>
Subject: Re: ipfilter
To: proff@suburbia.net
Date: Tue, 11 Mar 1997 19:39:10 +1100 (EDT)
Cc: moke@fools.ecpnet.com, hackers@freebsd.org
In-Reply-To: <19970311052941.24196.qmail@suburbia.net> from "proff@suburbia.net" at Mar 11, 97 04:29:41 pm
X-Mailer: ELM [version 2.4 PL23]
Content-Type: text
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

In some mail from proff@suburbia.net, sie said:
> 
> > I saw some parts of ipfilter in the -current source code. It appears to be
> > non-compiling from my short try at it, just what is the status on this
> > piece of code?
> 
> Avalon has neglected to cvs import BSD/Makefile{,.ipsend}, and the
> module code has not yet been modified to handle *cdevsw's, or devfs
> registrations.  Darren informed me that he has a mln_ipl.c etc with
> *cdevsw [etc] support, so it is perhaps a cvs mystery as to why we
> don't see it in the tree.  The kernel and i386/conf code looks
> correct. Stub makefiles in src/sbin and src/lkm also need creating.

At first, it was brought to my attention that I was using CVS incorrectly
in the FreeBSD environment, so I've cooled off for a bit.

Second, someone mentioned that prototyping was required for it to compile
properly in the kernel.

Third, it doesn't "make dep" very well due to the include's all using
"" and not <>.

This all became apparent after I imported 3.1.7 (and later goofed on
3.1.8 which Peter Wemm fixed).

The first issue is just becoming used to a new environment, the second
I was already working on for 3.2 and had no intention of introducing
prototypes to the 3.1 branch of IP Filter (I was primarily focusing on
making it stable).  The last will be addressed when I or someone else
takes the time to make the required changes and either send the patches
to someone who can commit them or commits them themselves (i.e. me).

Darren