From nobody Sun May 26 17:36:52 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VnQv91Gs5z5LPZq; Sun, 26 May 2024 17:36:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VnQv86Rm3z52kn; Sun, 26 May 2024 17:36:52 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716745012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HeRZ3mQ7uRNb0IeGW6UtxwD3JiFDC1g2SaCnFtOZSI8=; b=yCW8DTwvHoDMEMUFAsuI7nSCa4ewldO3O9Dq2bilNUqelhPu/CowA9uTjGLJnGfS1oijt5 hlMwbs41kMkDtMsrsVdAXbNLbdc/cZFQyjZKYAl/s5c4+Js4F4/Onea+JvJa5JkvOMQqLm Boglh9KCt7IXdpFRG1eMrPT+sfiLqdpo7qXQ9TmoXL15TewUqhmTvaI0ih1+F7JU8NSVrc s0Kq7QothyGf5Gl+SxE/PsK6B4osCKkgBSP8nlm99m5M/yMxnKeE6SxJka/+iVO5q/dXng Qx8P6c2TAJxH4FdY1B1V2hPj++5xayOKAtxflZDrqxyeIcVN/kDa2MkkKvOMzw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716745012; a=rsa-sha256; cv=none; b=KS2Lx3RIRPEy1LDa5n8ico6npgeTIc2N/x5tdMDBpz+zWGuD5jEoNu7rPtGzymiaz3XW58 KHMBrSveED3gLROpKfkZ/1VtuY4seNKnuGt91IewMurD3sdoJqUT8iF8O9UhXWnzvsnmkL IoIp1ScOcXEJOEusrHtR1bMRyIGXs9yGViDt5oFRWnxgQ/+tYJK1hLTb8q2iNJuGs7Sl71 Sd3RUEokLhbVbqOh2UHYUXq03kbsUYlLsa1G8EItDW4qpeHqCXcyDfXkId9k++dCYq4pcO PTE92G8CgJkrTlKQOY+WXOkLhvXZkTNK1hCOMuOT94N9aTWnJlkT1rMM/7KWJA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716745012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HeRZ3mQ7uRNb0IeGW6UtxwD3JiFDC1g2SaCnFtOZSI8=; b=GtqFZyW520W3gVXUQMs79Qj3SLJxsbAmRymumi4NCuTJRDOK9d2KYoJKWUp6gCNP+/o5oj YgSAOrGrk8lzSRnDNvi2JjZhsLEHukML4CjMZ84RwHk734xTgBqzEVuWio0MXFxfX33q7a upSHT5Y7J6IVQoF+uFQWXWPxLCBXuMWjotWEIg/IsIrfoYUefreEcoWypLN8DFC+QIAS3R ttj1sM8AsMhG443qUUDWg+kFrFoSP1sIrFGLlqAarNLrRMNaYaJgplUQuSp5uGJhPPwgpK k4WRZXj9BeQvu6ZBDfvnw0/y2KVj9msdaG3TIwWxFNxZs1tzr2S4TRCujwKRhg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VnQv863Cjz18S1; Sun, 26 May 2024 17:36:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 44QHaqws076174; Sun, 26 May 2024 17:36:52 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 44QHaqqX076171; Sun, 26 May 2024 17:36:52 GMT (envelope-from git) Date: Sun, 26 May 2024 17:36:52 GMT Message-Id: <202405261736.44QHaqqX076171@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ryan Libby Subject: git: 9c975a0d90f1 - main - pbuf_ctor(): Stop using LK_NOWAIT, use LK_NOWITNESS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rlibby X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9c975a0d90f1ee5259e53bebb48f9d7a5c2dd376 Auto-Submitted: auto-generated The branch main has been updated by rlibby: URL: https://cgit.FreeBSD.org/src/commit/?id=9c975a0d90f1ee5259e53bebb48f9d7a5c2dd376 commit 9c975a0d90f1ee5259e53bebb48f9d7a5c2dd376 Author: Ryan Libby AuthorDate: 2024-05-26 17:20:52 +0000 Commit: Ryan Libby CommitDate: 2024-05-26 17:20:52 +0000 pbuf_ctor(): Stop using LK_NOWAIT, use LK_NOWITNESS The LK_NOWAIT was added to suppress a witness warning, but LK_NOWITNESS is more what we mean. This makes pbuf_ctor() more consistent with buf_alloc(), although, unlike buf_alloc(), for pbuf there should not be any danger of a wild locker relying on the type stability of the buf to attempt a lock. That is, this is essentially cosmetic. Relevant history: - 531f8cfea06b Use dedicated lock name for pbufs - 5875b94c7493 buf_alloc(): lock the buffer with LK_NOWAIT - c9e023541aef pbuf_ctor(): lock the buffer with LK_NOWAIT - 1fb00c8f1060 buf_alloc(): Stop using LK_NOWAIT, use LK_NOWITNESS Reviewed by: rew, kib Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D45360 --- sys/vm/vm_pager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/vm/vm_pager.c b/sys/vm/vm_pager.c index 3550d5a6fac1..4da046ece50c 100644 --- a/sys/vm/vm_pager.c +++ b/sys/vm/vm_pager.c @@ -470,7 +470,7 @@ pbuf_ctor(void *mem, int size, void *arg, int flags) bp->b_ioflags = 0; bp->b_iodone = NULL; bp->b_error = 0; - BUF_LOCK(bp, LK_EXCLUSIVE | LK_NOWAIT, NULL); + BUF_LOCK(bp, LK_EXCLUSIVE | LK_NOWITNESS, NULL); return (0); }