Date: Wed, 5 Apr 2023 07:58:12 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Fernando Apestegu??a <fernape@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: e933541b2131 - main - devel/samurai: Fix if LOCALBASE is not /usr/local Message-ID: <ZC0qFG4RJTMQ5sx%2B@FreeBSD.org> In-Reply-To: <202304050543.3355hcZX012345@gitrepo.freebsd.org> References: <202304050543.3355hcZX012345@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 05, 2023 at 05:43:38AM +0000, Fernando Apestegu??a wrote:
> commit e933541b2131d644ce243630544bcf210fb4be84
>
> devel/samurai: Fix if LOCALBASE is not /usr/local
>
> PR: 270590
> Reported by: eric@camachat.org
> ...
> PORTNAME= samurai
> DISTVERSION= 1.2-16
> +PORTREVISION= 1
Needless bump for build-time change?
> -@@ -3,7 +3,7 @@
> - PREFIX=/usr/local
> +@@ -1,10 +1,10 @@
> + .POSIX:
> + .PHONY: all install clean
> +
> +-PREFIX=/usr/local
> ++PREFIX=${LOCALBASE}
This doesn't look right, PREFIX is semantically different from LOCALBASE even
though they typically point to the same path (PREFIX is where your generated
stuff goes, LOCALBASE is where you get precursors). If this program abuses
the PREFIX variable and it is actually meant to be LOCALBASE, it's better to
fix the Makefile or at least accompany such change with due comment.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZC0qFG4RJTMQ5sx%2B>