From owner-svn-src-stable-12@freebsd.org Tue Feb 12 01:24:27 2019 Return-Path: Delivered-To: svn-src-stable-12@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0DDF214EB6D1; Tue, 12 Feb 2019 01:24:27 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8CF3A94159; Tue, 12 Feb 2019 01:24:20 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1C1OIhV073610; Mon, 11 Feb 2019 17:24:18 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1C1OI5b073609; Mon, 11 Feb 2019 17:24:18 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201902120124.x1C1OI5b073609@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r344027 - in stable/12/sys: dev/vmware/vmxnet3 modules/vmware/vmxnet3 net In-Reply-To: <62d2dcc1-5bde-1eda-6d9f-82138932cb36@FreeBSD.org> To: John Baldwin Date: Mon, 11 Feb 2019 17:24:18 -0800 (PST) CC: rgrimes@FreeBSD.org, Patrick Kelsey , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-stable-12@FreeBSD.org Reply-To: rgrimes@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 8CF3A94159 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_SHORT(-0.95)[-0.946,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-stable-12@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for only the 12-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2019 01:24:27 -0000 > On 2/11/19 4:26 PM, Rodney W. Grimes wrote: > >> Author: pkelsey > >> Date: Mon Feb 11 23:24:39 2019 > >> New Revision: 344027 > >> URL: https://svnweb.freebsd.org/changeset/base/344027 > >> > >> Log: > >> MFC r343291: > >> Convert vmx(4) to being an iflib driver. > > > > I strongly object to this MFC, given the current number > > of 12.0 RELEASE related iflib problems we have it is > > foolish of us to iflib any more drivers in 12.0 > > This isn't the release branch though and presumably we have some time before > 12.1 ships. If there are reports of vmx(4) breakage on stable before 12.1 > we could always revert this commit then? At this point the status if iflib in stable/12 is not certain, but what is certain is this merge to 12 is probably going to break someones system and at best is an unknown if working. People DO run stable/12, breaking it is a no no. Has the committer even booted this code in a stable/12 system and run a serious amount of testing on it? > > I've heard of some EN's for 12.0 for iflib fixes. Are those fixes in stable/12 > yet or are we still waiting for them to land in HEAD and/or be merged? I sent a ping out earlier today trying to find that out. I belive that some of them are merged to stable/12, some are waiting to be merged, I do believe most if not all are commited to head. But that is orthagonal to breaking another driver in stable/12. No one should have the attitude that "oh, we have until 12.1 release to fix it." The branch is called stable, you should never break it! -- Rod Grimes rgrimes@freebsd.org