Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Nov 2020 15:51:13 -0500
From:      Diane Bruce <db@db.net>
To:        Kyle Evans <kevans@freebsd.org>
Cc:        Diane Bruce <db@freebsd.org>, ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r556026 - in head/comms/fldigi: . files
Message-ID:  <20201122205113.GA36114@night.db.net>
In-Reply-To: <CACNAnaF2GiXk0i%2BZMoBHex1YfUjAeQPC0ZaFcHVD1LOSGDw6fw@mail.gmail.com>
References:  <202011220149.0AM1nocl029418@repo.freebsd.org> <CACNAnaF2GiXk0i%2BZMoBHex1YfUjAeQPC0ZaFcHVD1LOSGDw6fw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 21, 2020 at 09:05:07PM -0600, Kyle Evans wrote:
> On Sat, Nov 21, 2020 at 7:49 PM Diane Bruce <db@freebsd.org> wrote:
> >
> > Author: db
> > Date: Sun Nov 22 01:49:49 2020
> > New Revision: 556026
> > URL: https://svnweb.freebsd.org/changeset/ports/556026
> >
> > Log:
> >   - sed is broken on 11.4 so install and use gsed instead.
> >
> 
> Well, kind of. :-)
> 
> Were you hitting an error, or just that it wasn't doing the right
> thing? I note that at least:
> 
> s/\r//g
> 
> This one will globally eliminate all of your plain old 'r' characters
> on 11.4, but will no longer in 12.2.

Yep. That's exactly what it did instead of the stray carriage returns
that somehow ended up from an operation by Asciidoc... (Look at original
commit I made a few days ago on this) ... I believe AsciiDoc has
a regression but haven't found it yet. So yes this sed fix is a hack
and in doing so I stumbled over this treat in 11.4 ;)

-// Table Of Contents generato\n\
+// Table Of Contents generator\n\

I was going to query if this was a known bug so you've answered
my question already.

Now for second bug Asciidoc...
I was going to start digging into Asciidoc to see if I can spot something
obvious.

Does not have this bug
Name           : asciidoc
Version        : 9.0.2
Installed on   : Sun Sep 13 17:40:19 2020 EDT 
Origin         : textproc/asciidoc


Does have this bug.
Name           : asciidoc
Version        : 9.0.4
Installed on   : Sat Nov 21 11:55:38 2020 EST
Origin         : textproc/asciidoc

results in:
-<div id=\"toc\">^M\n\
-  <div id=\"toctitle\">Table of Contents</div>^M\n\
-  <noscript><p><b>JavaScript must be enabled in your browser to display the table of contents.</b></p></noscript>^M\n\

Embedded carriage returns which confuses clang badly...

> 
> Thanks,
> 
> Kyle Evans

Thank you. 

Diane Bruce
-- 
- db@FreeBSD.org db@db.net http://www.db.net/~db



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201122205113.GA36114>