From owner-freebsd-ports  Tue Mar 14 22: 5:31 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from tardis.patho.gen.nz (tardis.patho.gen.nz [203.97.2.226])
	by hub.freebsd.org (Postfix) with ESMTP
	id 87BED37B8E6; Tue, 14 Mar 2000 22:05:27 -0800 (PST)
	(envelope-from jabley@tardis.patho.gen.nz)
Received: (from jabley@localhost)
	by tardis.patho.gen.nz (8.9.3/8.9.3) id TAA18310;
	Wed, 15 Mar 2000 19:05:25 +1300 (NZDT)
Date: Wed, 15 Mar 2000 19:05:23 +1300
From: Joe Abley <jabley@patho.gen.nz>
To: freebsd-ports@freebsd.org
Cc: green@freebsd.org
Subject: Changed assumptions in 3.4-STABLE for OpenSSH port
Message-ID: <20000315190519.A30928@patho.gen.nz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 1.0.1i
X-Files: the Truth is Out There
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

OpenSSH port:

  $FreeBSD: ports/security/openssh/Makefile,v 1.47 2000/03/03 06:10:02 \
    green Exp $

fails to build on:

  FreeBSD drone5.qsi.net.nz 3.4-STABLE FreeBSD 3.4-STABLE #0: Wed Mar 15 \
    06:51:04 NZDT 2000     jabley@drone5.qsi.net.nz:/usr/src/sys/compile/DRONE \
    i386

which was supped and world made within the past two days. The build
fails with:

===>  Building for OpenSSH-1.2.2
===> lib
Warning: Object directory not changed from original /usr/ports/security/openssh/work/ssh/lib
cc -O -pipe -I/usr/ports/security/openssh/work/ssh/lib/.. -I/usr/local/include  -I/usr/ports/security/openssh/work/ssh/lib/.. -I/usr/local/usr/include -c /usr/ports/security/openssh/work/ssh/lib/../authfd.c -o authfd.o
In file included from /usr/ports/security/openssh/work/ssh/lib/../authfd.c:16:
/usr/ports/security/openssh/work/ssh/lib/../includes.h:72: warning: redefinition of `sa_family_t'
/usr/include/sys/socket.h:47: warning: `sa_family_t' previously declared here
/usr/ports/security/openssh/work/ssh/lib/../includes.h:73: conflicting types for `socklen_t'
/usr/include/sys/socket.h:48: previous declaration of `socklen_t'
*** Error code 1

Stop.

This appears to be a result of logic such as:

  #if defined(__FreeBSD__) && __FreeBSD__ <= 3
  /*
   * Data types.
   */
  typedef u_char          sa_family_t;
  typedef u_int32_t       socklen_t;

This logic does not appear to apply with recent 3.4-STABLE.

Removing those two typedef's allows the build to proceed. I'd supply
a patch, but since I don't know the history of sa_family_t and
socklen_t in /usr/include/sys/socket.h, I don't feel confident that
I could suggest the correct solution.


Joe


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message