Date: Thu, 31 Jan 2019 14:09:56 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Diane Bruce <db@db.net> Cc: Diane Bruce <db@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r491675 - in head/comms/fldigi: . files Message-ID: <20190131140956.GA93408@FreeBSD.org> In-Reply-To: <20190131133732.GA76004@night.db.net> References: <201901310204.x0V24U5Y032910@repo.freebsd.org> <20190131021439.GA94120@FreeBSD.org> <20190131133732.GA76004@night.db.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 31, 2019 at 08:37:32AM -0500, Diane Bruce wrote: > On Thu, Jan 31, 2019 at 02:14:39AM +0000, Alexey Dokuchaev wrote: > > ... > > These two patches were essentially not changed and should have been > > dropped from the commit batch to reduce repo churn and diff noise. > > Tell that to the make makepatch maintainers please. Well, no: makepatch would never (and it's not supposed to) be so smart to detect/mitigate these things. Evaluating a diff (and commit hygiene in general) is committer's responsibility. That said, I understand that worrying about diff S/N is not for everyone, just want to point out that one can control it, and quite easily: simple svn revert after svn diff/st is usually sufficient. Clean diffs help the readers, make svn blame'ing and source archaeology in general easier. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190131140956.GA93408>