From owner-freebsd-ports@FreeBSD.ORG  Sun Jan 25 16:00:09 2015
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E5F5BB33;
 Sun, 25 Jan 2015 16:00:09 +0000 (UTC)
Received: from tensor.andric.com (unknown
 [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "tensor.andric.com",
 Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9F2A6353;
 Sun, 25 Jan 2015 16:00:09 +0000 (UTC)
Received: from [IPv6:2001:7b8:3a7::79cb:885c:d74b:842b] (unknown
 [IPv6:2001:7b8:3a7:0:79cb:885c:d74b:842b])
 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by tensor.andric.com (Postfix) with ESMTPSA id F385F5C2E;
 Sun, 25 Jan 2015 17:00:04 +0100 (CET)
Subject: Re: head/graphics/svgalib does not build in poudriere
Mime-Version: 1.0 (Mac OS X Mail 8.1 \(1993\))
Content-Type: multipart/signed;
 boundary="Apple-Mail=_79C608E8-141C-43F1-AA66-147FB9B3587E";
 protocol="application/pgp-signature"; micalg=pgp-sha1
X-Pgp-Agent: GPGMail 2.5b4
From: Dimitry Andric <dim@FreeBSD.org>
In-Reply-To: <20150125155526.GA2744@c720-r276659>
Date: Sun, 25 Jan 2015 17:00:02 +0100
Message-Id: <0B227275-7F6D-4E39-AC5F-B4E2DDB73EBC@FreeBSD.org>
References: <20150125075122.GA1377@c720-r276659>
 <20150125101145.GA1906@c720-r276659>
 <FBA4BAED-9EE7-4EFA-8EA0-5D4FE9ED0590@FreeBSD.org>
 <20150125155526.GA2744@c720-r276659>
To: Matthias Apitz <guru@unixarea.de>
X-Mailer: Apple Mail (2.1993)
Cc: freebsd-ports@freebsd.org, zeising@FreeBSD.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Jan 2015 16:00:10 -0000


--Apple-Mail=_79C608E8-141C-43F1-AA66-147FB9B3587E
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 25 Jan 2015, at 16:55, Matthias Apitz <guru@unixarea.de> wrote:
..
> The port compiles fine the normal way:
> 
> # cd graphics/svgalib
> # make package
> 
> without your proposed change; it does not compile in poudriere.

If poudriere compiles it differently than normal, I think it is a
problem in poudriere, or maybe in poudriere's configuration.  From your
pasted command lines, it seems poudriere disables optimization?  That
does not look good...


> And to incorporate your change it would need an additional patch file,
> is this what you want me to do?

It's nice to fix the code, as gnu98 inline semantics are different from
c99.  But maybe it is better to fix the root cause (poudriere) first.

-Dimitry


--Apple-Mail=_79C608E8-141C-43F1-AA66-147FB9B3587E
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.26

iEYEARECAAYFAlTFEw0ACgkQsF6jCi4glqO2KACg68saseJO6vePhCbIcqSYINJf
+S8An01TNM9aBfnIPaZY6Egb8JHLcnRR
=a6Yb
-----END PGP SIGNATURE-----

--Apple-Mail=_79C608E8-141C-43F1-AA66-147FB9B3587E--