From owner-freebsd-bugs  Fri Feb 28 22:30:14 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id WAA13854
          for bugs-outgoing; Fri, 28 Feb 1997 22:30:14 -0800 (PST)
Received: from crh.cl.msu.edu (crh.cl.msu.edu [35.8.1.24])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id WAA13848
          for <freebsd-bugs@FreeBSD.org>; Fri, 28 Feb 1997 22:30:12 -0800 (PST)
Received: (from henrich@localhost)
          by crh.cl.msu.edu (8.8.5/8.8.4)
	  id BAA09181; Sat, 1 Mar 1997 01:29:12 -0500 (EST)
From: Charles Henrich <henrich@crh.cl.msu.edu>
Message-Id: <199703010629.BAA09181@crh.cl.msu.edu>
Subject: Re: mail.local modifications?
To: jkh@time.cdrom.com (Jordan K. Hubbard)
Date: Sat, 1 Mar 1997 01:29:12 -0500 (EST)
Cc: bde@zeta.org.au, mpp@freefall.freebsd.org, freebsd-bugs@FreeBSD.org
In-Reply-To: <1855.857197505@time.cdrom.com> from "Jordan K. Hubbard" at "Feb 28, 97 10:25:05 pm"
X-Mailer: ELM [version 2.4ME+ PL22 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-bugs@FreeBSD.org
X-Loop: FreeBSD.org
Precedence: bulk

> I think you may have missed the point.  I can't speak for everyone
> else, but if someone sends me a patch which doesn't apply, and I've
> got 5001 other things to do (that being a constant), I simply won't
> bother with it.  This isn't snobbery, this is a simple matter of
> saying "huh, oh well!  I don't have time to grub through diff output,
> and a patch reject implies problems on the submitter's end in 99.9% of
> the cases (invalidating the patch) so I guess I'll come back to this
> later and go on to the next item in my list (a new stack frame is
> pushed, never to return :)."

And thats one hudred percent and completely acceptable and accepted behavior.
The problem is that the patch DID work, I didnt cut'n'paste, I read it in with
VI, made extra sure it was perfect, applied it twice to my source copies,
before sending it in.  The comment I got back was "its got spaces in it" which
it did, and I took as meaning he didnt like my spaces.  Not that it didnt
apply.

> The moral of the story?  Provide proper diffs, don't just go
> cut-n-paste happy.  Overwork is the order of the day here, and if you
> make it harder on the committer then he's likely to simply move on to
> the next task and drop yours on the floor.  Given the backlog of tasks
> we have, I also wouldn't have it any other way.

Me neither.  I understand this, I appreciate this, perhaps my interpretation of
his message didnt match his message.  But the patch did apply for me every damn
time, hell thats why I included the command I used to make the diff, just so
people could point out if I was doing something boneheaded.

-Crh

       Charles Henrich     Michigan State University     henrich@msu.edu

                         http://pilot.msu.edu/~henrich