From owner-svn-ports-head@FreeBSD.ORG Thu Nov 27 16:00:49 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 88FA428B; Thu, 27 Nov 2014 16:00:49 +0000 (UTC) Received: from mailrelay002.isp.belgacom.be (mailrelay002.isp.belgacom.be [195.238.6.175]) by mx1.freebsd.org (Postfix) with ESMTP id BECD5893; Thu, 27 Nov 2014 16:00:48 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Al4GAJJJd1RbsIqE/2dsb2JhbABbgwZRyBmGUQKBCRcBAQEBAX2EAgEBAQMBOhweBQULCw4KCSUPKh4GExuIHA0B0iIBAQEBAQEBAwEBAQEBHZBVJgeETQEEl0yHNIF1lSiCN4FGPjCCSgEBAQ Received: from 132.138-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.138.132]) by relay.skynet.be with ESMTP; 27 Nov 2014 17:00:40 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id sARG0dIL003677; Thu, 27 Nov 2014 17:00:39 +0100 (CET) (envelope-from tijl@FreeBSD.org) Date: Thu, 27 Nov 2014 17:00:38 +0100 From: Tijl Coosemans To: John Marino Subject: Re: svn commit: r373458 - in head/www: linux-c6-flashplugin11 linux-f10-flashplugin11 Message-ID: <20141127170038.2d48e014@kalimero.tijl.coosemans.org> In-Reply-To: <5476E1A5.1010307@marino.st> References: <201411261948.sAQJmO9U029389@svn.freebsd.org> <20141126211459.241dfadb@kalimero.tijl.coosemans.org> <547635FD.5080407@marino.st> <20141127092101.3f977182@kalimero.tijl.coosemans.org> <5476E1A5.1010307@marino.st> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, jbeich@vfemail.net, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 16:00:49 -0000 On Thu, 27 Nov 2014 09:32:37 +0100 John Marino wrote: > On 11/27/2014 09:21, Tijl Coosemans wrote: >> On Wed, 26 Nov 2014 21:20:13 +0100 John Marino wrote: >>> On 11/26/2014 21:14, Tijl Coosemans wrote: >>>> On Wed, 26 Nov 2014 19:48:24 +0000 (UTC) John Marino wrote: >>>>> +%%NO_ALSA%%%%LINUXBASE%%/usr/lib/libflashsupport.so >>>>> +%%NO_ALSA%%@dir %%LINUXBASE%%/usr/lib >>>>> +%%NO_ALSA%%@dir %%LINUXBASE%%/usr >>>>> +%%NO_ALSA%%@dir %%LINUXBASE%% >>>>> +%%NO_ALSA%%@dir %%COMPATDIR%% >>>> >>>> Traditionally /compat is a symlink to /usr/compat, so I'm not sure it's >>>> safe to delete it like this. But even if it is this port depends on >>>> emulators/linux_base so none of these @dir are necessary. >>> >>> The port was creating empty directories in stagedir when ALSA option is >>> off. So at least in one case, they are necessary (or deleting from >>> stagedir is necessary). Nothing is getting deleted. >> >> The directory %%LINUXBASE%%/usr/lib isn't empty. It contains >> libflashsupport.so. And that directory belongs to emulators/linux_base >> so this port does not have to list it with @dir. > > So at worst it's a no-op, right? pkg won't create a directory if it > already exists - and won't delete if it's still contains files. Yes, you're right, it's always a no-op. > make check-plist was coming back with *errors*. I don't want to accept > errors as normal. No port should fail -t checks in poudriere. Do you > know a better solution that doesn't result in make check-plist failure? > > Perhaps removing the directories from stagedir instead? No the directory isn't empty so you cannot delete it. I think the proper fix is to add /usr/compat to /etc/mtree/BSD.usr.dist and let the base system create /compat as a symlink to it. Then @dir %%COMPATDIR%% can be removed. The others can stay.