From owner-freebsd-ports@FreeBSD.ORG Wed Dec 8 13:52:15 2010 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 188CD1065670; Wed, 8 Dec 2010 13:52:15 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from unimail.uni-dortmund.de (mx1.HRZ.Uni-Dortmund.DE [129.217.128.51]) by mx1.freebsd.org (Postfix) with ESMTP id 8BE698FC18; Wed, 8 Dec 2010 13:52:14 +0000 (UTC) Received: from [192.168.0.93] (g226229216.adsl.alicedsl.de [92.226.229.216]) (authenticated bits=0) by unimail.uni-dortmund.de (8.14.4/8.14.4) with ESMTP id oB8DLPIE004863 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NOT); Wed, 8 Dec 2010 14:21:26 +0100 (CET) Message-ID: <4CFF8653.3090104@FreeBSD.org> Date: Wed, 08 Dec 2010 14:21:23 +0100 From: Matthias Andree User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; de; rv:1.9.2.12) Gecko/20101027 Lightning/1.0b2 Thunderbird/3.1.6 MIME-Version: 1.0 To: ports@FreeBSD.org References: <201012071304.oB7D4cpU081988@repoman.freebsd.org> <20101208122105.6E9B35A900A@jester1b.ixsystems.com> In-Reply-To: <20101208122105.6E9B35A900A@jester1b.ixsystems.com> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: sergei@FreeBSD.org Subject: NOPORTDOCS leftovers in news/newsstar (was: cvs commit: ports/news/newsstar Makefile) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2010 13:52:15 -0000 Am 08.12.2010 13:21, schrieb QAT@FreeBSD.org: > The Restless Daemon identified a mtree error while trying to build: > newsstar-1.5.4 maintained by ports@FreeBSD.org > Makefile ident: $FreeBSD: ports/news/newsstar/Makefile,v 1.21 2010/12/07 13:04:38 mandree Exp $ > > Excerpt from http://QAT.TecNik93.com/logs/8-STABLE-NPD/newsstar-1.5.4.log : ... > Deleting newsstar-1.5.4 > ================================================================ > > === Checking filesystem state > list of extra files and directories in / (not present before this port was installed but present after it was deinstalled) > 49506471 4 drwxr-xr-x 2 root wheel 512 Dec 8 12:21 usr/local/share/doc/newsstar > 49506472 16 -rw-r--r-- 1 root wheel 6926 Dec 8 12:21 usr/local/share/doc/newsstar/index.html ... > 49506495 8 -rw-r--r-- 1 root wheel 2158 Dec 8 12:21 usr/local/share/doc/newsstar/NEWS > ================================================================ > build of /usr/ports/news/newsstar ended at Wed Dec 8 12:21:04 UTC 2010 Sorry for the mess -- I wonder why my "sudo env NOPORTDOCS=1 port test" missed to find that. My Tinderbox builds run without NOPORTDOCS, so they wouldn't complain. Given this was a long-standing issue that should have affected previous newsstar versions too (assuming that my HAS_CONFIGURE -> GNU_CONFIGURE change hasn't broken things), "port test" may have been blind because there were previous leftovers from my fixing 1.5.3 before upgrading to 1.5.4. Before I start longish testing: has anyone seen such things happen before (i. e. port test missing "extra" files?) Sergei, could "port test" explicitly probe if $DOCSDIR is present and/or nonempty (something equivalent to checking if there is output from "find $DOCSDIR \! -type d"), in addition to the mtree checks? Any insights? So, I've fixed that in ports CVS, however should we deal with the leftovers? I can fancy the following: 1. assume few people grabbed the broken 1.5.4 AND installed NORPORTDOCS, i.e. don't care and let users deal with that on the next major FreeBSD upgrade when they're advised to purge $PREFIX and rebuild all ports. 2a. add a message displayed after NOPORTDOCS builds if a ${DOCSDIR} leftover from 1.5.4 is present so that the user can deal with it 2b. ditto, but delete ${DOCSDIR} instead of telling user to do so 3. add a message to ports/UPDATING (seems overkill) Opinions? Thanks. Best regards Matthias