From owner-freebsd-current@FreeBSD.ORG  Tue Mar 21 06:43:34 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CC19216A401
	for <freebsd-current@freebsd.org>; Tue, 21 Mar 2006 06:43:34 +0000 (UTC)
	(envelope-from ganbold@micom.mng.net)
Received: from publicd.ub.mng.net (publicd.ub.mng.net [202.179.0.88])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E634843D5F
	for <freebsd-current@freebsd.org>; Tue, 21 Mar 2006 06:43:30 +0000 (GMT)
	(envelope-from ganbold@micom.mng.net)
Received: from [202.179.0.164] (helo=[192.168.0.18])
	by publicd.ub.mng.net with esmtpa (Exim 4.60 (FreeBSD))
	(envelope-from <ganbold@micom.mng.net>)
	id 1FLaf5-000ICo-9V; Tue, 21 Mar 2006 14:48:11 +0800
Message-ID: <441F9F9D.9060504@micom.mng.net>
Date: Tue, 21 Mar 2006 14:39:25 +0800
From: Ganbold <ganbold@micom.mng.net>
User-Agent: Thunderbird 1.5 (X11/20060202)
MIME-Version: 1.0
To: Giorgos Keramidas <keramida@ceid.upatras.gr>
References: <441F7635.4090300@micom.mng.net>
	<441F7991.8000505@micom.mng.net>	<441F7635.4090300@micom.mng.net>
	<20060321041219.GA31213@flame.pc>
In-Reply-To: <20060321041219.GA31213@flame.pc>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@freebsd.org
Subject: Re: rcorder problem when booting CURRENT
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Mar 2006 06:43:34 -0000

Giorgos Keramidas wrote:
> On 2006-03-21 11:42, Ganbold <ganbold@micom.mng.net> wrote:
>   
>> Hi,
>>
>> I have just upgraded my machine from FreeBSD-6.1-PRERELEASE to
>> FreeBSD-7.0-CURRENT.
>>
>> gw# uname -an
>> FreeBSD gw.micom.mng.net 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Tue Mar 21
>> 09:00:50 ULAT 2006 tsgan@gw.micom.mng.net:/usr/obj/usr/src/sys/GW  i386
>>
>> When I restarted the machine right after mergemaster, it said following
>> error and
>> didn't run rc scripts. I had to manually start some scripts.
>>
>> ...
>> pid 104(rcorder), uid0: exited on signal 11 (core dumped)
>> Segmentation fault (core dumped)
>> ...
>> [snip stack trace without symbols]
>>     
>
> On 2006-03-21 11:57, Ganbold <ganbold@micom.mng.net> wrote:
>   
>> Sorry for the noise. I read UPDATING and found out that
>> dansguardian startup script was causing the problem.
>>     
>
> Still a core dump is a core dump.  Can you build a debugging version of
> rcorder and try again?  This time the stack trace may be more useful.
>   

Following patch fixed rcorder problem. I'm not sure whether this is 
correct fix or not.

--- rcorder.c   Tue Jan 17 16:01:00 2006
+++ rcorder.c-new       Tue Mar 21 14:10:41 2006
@@ -798,8 +798,10 @@

         DPRINTF((stderr, "nuking %s\n", fnode->filename));
         if (was_set == 0) {
-               free(fnode->filename);
-               free(fnode);
+               if(fnode->next == NULL){
+                       free(fnode->filename);
+                       free(fnode);
+               }
         }
  }

Ganbold