From owner-freebsd-current@freebsd.org Thu Oct 24 18:07:22 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2E27E176225 for ; Thu, 24 Oct 2019 18:07:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46zZvt0SLLz4Q7X; Thu, 24 Oct 2019 18:07:22 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 85770B8F9; Thu, 24 Oct 2019 18:07:21 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: make delete-old: missing some files? To: Alexey Dokuchaev Cc: freebsd-current@FreeBSD.org, Xin LI References: <20191018170519.GA15695@regency.nsu.ru> <20191023034208.GA97072@regency.nsu.ru> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Thu, 24 Oct 2019 11:07:16 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191023034208.GA97072@regency.nsu.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Oct 2019 18:07:22 -0000 On 10/22/19 8:42 PM, Alexey Dokuchaev wrote: > On Tue, Oct 22, 2019 at 04:34:53PM -0700, John Baldwin wrote: >> On 10/18/19 10:05 AM, Alexey Dokuchaev wrote: >>> hi there, >>> >>> i've made my -CURRENT world and installed, but "make delete-old" tells >>> me it cannot remove some directories: >>> >>>>>> Removing old directories >>> rmdir: /usr/share/dtrace: Directory not empty >>> rmdir: /usr/lib/dtrace: Directory not empty > > Apparently, these are because I've started to put WITHOUT_CDDL=yes in > /etc/src.conf since recently: > > $ find /usr/lib/dtrace -type f > /usr/lib/dtrace/siftr.d > /usr/lib/dtrace/mbuf.d > /usr/lib/dtrace/socket.d > > $ find /usr/share/dtrace -type f > /usr/share/dtrace/nfsattrstats > /usr/share/dtrace/siftr > /usr/share/dtrace/blocking > /usr/share/dtrace/tcpdebug> > I can see some dtrace/*.d files in OptionalObsoleteFiles.inc, perhaps > these are missing? Probably. >>> # find /usr/lib/debug/usr/lib/engines >>> /usr/lib/debug/usr/lib/engines >>> /usr/lib/debug/usr/lib/engines/lib4758cca.so.debug >>> ... >> >> These are from the OpenSSL 1.1.1 commit. However, they are tagged as >> OLD_LIBS and check-old-libs and delete-old-libs should be automatically >> deleting these? Does 'make check-old' report these files as >> old libraries? > > I've manually placed one of those back on the filesystem and `make > check-old' reported it (twice!) under libraries. But after r353907 it > get cleaned up properly with `make delete-old'. Hmm, then 'make delete-old-libs' should already delete them without needing r353907. The issue with r353907 is if someone doesn't delete the actual libraries via 'make delete-old-libs' but then tries to debug an application that was using the old openssl and crashed, we'd no longer have debug symbols if the crash was in one of those libraries. That matters less for OpenSSL engines, but matters more for something like libutil, etc. hence why we delete debug symbols as part of delete-old-libs instead of delete-old. If 'make delete-old-libs' deletes these files already, then we should probably revert r353907. -- John Baldwin