From owner-svn-src-head@FreeBSD.ORG  Mon Nov 18 14:55:33 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C55FC242;
 Mon, 18 Nov 2013 14:55:33 +0000 (UTC)
Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D43202FE7;
 Mon, 18 Nov 2013 14:55:32 +0000 (UTC)
Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52]
 helo=damnhippie.dyndns.org)
 by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256)
 (Exim 4.72) (envelope-from <ian@FreeBSD.org>)
 id 1ViQEY-000NKp-BN; Mon, 18 Nov 2013 14:55:26 +0000
Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240])
 by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id rAIEtN3q078488;
 Mon, 18 Nov 2013 07:55:23 -0700 (MST) (envelope-from ian@FreeBSD.org)
X-Mail-Handler: Dyn Standard SMTP by Dyn
X-Originating-IP: 24.8.230.52
X-Report-Abuse-To: abuse@dyndns.com (see
 http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse
 reporting information)
X-MHO-User: U2FsdGVkX1+yz5OKJMrGzsy5fRkUEhUi
Subject: Re: svn commit: r258155 - head/sys/dev/qlxgbe
From: Ian Lepore <ian@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
In-Reply-To: <20131118142226.GA52991@FreeBSD.org>
References: <201311150126.rAF1QPZq077225@svn.freebsd.org>
 <20131118142226.GA52991@FreeBSD.org>
Content-Type: text/plain; charset="us-ascii"
Date: Mon, 18 Nov 2013 07:55:23 -0700
Message-ID: <1384786523.31172.467.camel@revolution.hippie.lan>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
 src-committers@FreeBSD.org, David C Somayajulu <davidcs@FreeBSD.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Nov 2013 14:55:33 -0000

On Mon, 2013-11-18 at 14:22 +0000, Alexey Dokuchaev wrote:
> On Fri, Nov 15, 2013 at 01:26:25AM +0000, David C Somayajulu wrote:
> > New Revision: 258155
> > URL: http://svnweb.freebsd.org/changeset/base/258155
> > 
> > Log:
> >   ql_hw.[c,h]: set minimum thresholds on pkt size for lro path.
> >   ql_ioctl.c: validate the length and address of buffer passed to QL_RD_FW_DUMP
> >   
> >   Submitted by:David C Somayajulu
> 
> "Submitted by" tag is redundant when submitter == committer.  In these
> cases, it simply clutters the log rather than adds anything useful.
> 
> ./danfe

Not always.  I put myself in Submitted By when I'm committing a patch
from a PR I filed years ago before I was a committer (sadly there are
enough of these that it's not a thing that just happened once).

-- Ian