From owner-dev-commits-src-branches@freebsd.org Wed Dec 30 18:13:41 2020 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C4F304CABF2; Wed, 30 Dec 2020 18:13:41 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D5fYK4twWz4T6S; Wed, 30 Dec 2020 18:13:41 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qv1-f47.google.com with SMTP id l14so8043166qvh.2; Wed, 30 Dec 2020 10:13:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uuzQj6MmchJ23JjyiOOxBhQM0EATZLEZGJypAuZJvxs=; b=uHV+fFhnTOjUv2e8j89XVOV1kngSiX/a9ePKZ7n8O4J32wSNrb7hKMOXUd61TBcEUP nfwrDk893GykTC2FVpf1mgGnSVZ6G2l0Ba0TjcY9MwY42yItiTOwShUC9LuZGFHZDuDr 8+hERhZrMymOJrOOTwzL67EyJQ9sG2CcxOHGwryRkStpF/fNH9/dhhxzOIu+gyHWqvao HG/XetYRyvk7DiUTylPaSQCWYbE4sDoP9okXC5Sp3Q38g6+zspyY/k0p9L0cqGjtmx2g IkuQZueh5bDOeTBE56hQA/EBGy6uY6IPueqkKe7jwXWI9asSwdzCL9N6E2p6v3CVUY+t a46g== X-Gm-Message-State: AOAM531J+VZZk58/XVmKY8dDvemeiKzGKl8KDS8/qxNHx2PWJE78MhEn ckyVrGIWrjK1YnQ31MWFrQAngU+wzYzyBg== X-Google-Smtp-Source: ABdhPJzE038MNmcA0eVs1g3WpJsXyqmKbSiveha1WXuUGetKxKxyiSvYUg2VKrrPK05DWGrZYBMmQQ== X-Received: by 2002:a0c:8304:: with SMTP id j4mr24045763qva.18.1609352020156; Wed, 30 Dec 2020 10:13:40 -0800 (PST) Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com. [209.85.219.53]) by smtp.gmail.com with ESMTPSA id n4sm28784769qtl.22.2020.12.30.10.13.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Dec 2020 10:13:40 -0800 (PST) Received: by mail-qv1-f53.google.com with SMTP id a4so8004152qvd.12; Wed, 30 Dec 2020 10:13:39 -0800 (PST) X-Received: by 2002:ad4:5762:: with SMTP id r2mr58238716qvx.45.1609352019670; Wed, 30 Dec 2020 10:13:39 -0800 (PST) MIME-Version: 1.0 References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Wed, 30 Dec 2020 10:13:28 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 To: Konstantin Belousov Cc: Kyle Evans , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4D5fYK4twWz4T6S X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for the stable branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Dec 2020 18:13:41 -0000 On Wed, Dec 30, 2020 at 3:33 AM Konstantin Belousov wrote: > > On Tue, Dec 29, 2020 at 07:10:02PM -0800, Ryan Libby wrote: > > I checked amd64 and it failed due to pkru. I don't think we care to fix > > that either, but we technically could of course. For amd64 the external > > toolchain with gcc 6.4 is broken at the moment but will be fixed after a > > few more MFCs. > > Could you be more specific, please? > > What is broken with PKRU, the gcc 6.4 build? For kernel, or libc? > Does it work with not-so-ancient gcc? Sorry, I wasn't clear. gcc 6.4 from the external toolchain is fine with pkru. Separately, there are just a few remaining MFCs to make gcc 6.4 work out of the box with no WERROR suppression. gcc 4.2.1 for amd64 is broken, most immediately because of pkru in libc (because of new instructions and because of a use of the ifunc attribute). This is what I meant to say was technically fixable, but that we didn't care. (For those reading along who haven't checked, pkru(3) is x86-only, at least so far.) Ryan