From owner-cvs-all  Mon Apr 20 19:11:14 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id TAA26007
          for cvs-all-outgoing; Mon, 20 Apr 1998 19:11:14 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA25963;
          Tue, 21 Apr 1998 02:10:55 GMT
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id MAA31545;
	Tue, 21 Apr 1998 12:07:27 +1000
Date: Tue, 21 Apr 1998 12:07:27 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199804210207.MAA31545@godzilla.zeta.org.au>
To: bde@zeta.org.au, brian@Awfulhak.org
Subject: Re: cvs commit: src/usr.sbin/ppp bundle.c fsm.c id.c ipcp.c lcp.c log.h lqr.c modem.c prompt.h sig.c slcompress.c timer.c
Cc: brian@FreeBSD.ORG, cvs-committers@FreeBSD.ORG
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>> Ifdefing the use of __attribute__ is unnecessary because <sys/cdefs.h>
>> already defines away __attribute__ (#if __GNUC__ < 2).
>...
>So should <sys/cdefs.h> be included from my .h files ?  It seems 
>prone to error if I expect the .c to include it before the .h with 
>__attribute__.

See style(9), although its points about cdefs.h are out of date.
Almost all CSRG sources depend on it defining __P(), but not all of
them include one of the 2 headers that are documented to include it
(<sys/types.h> and (indirectly) <sys/param.h>).  In practice, it is
guaranteed to be included by almost every header in /usr/include,
because application headers that declare a prototype should include
it (for C++ support if not for __P()).

However, all of this is unportable.  I now like your original version
better :-).

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message