From owner-svn-src-all@freebsd.org Mon Oct 19 18:12:35 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0E7BD4304E4; Mon, 19 Oct 2020 18:12:35 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4CFPxG44DNz3yWv; Mon, 19 Oct 2020 18:12:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 09JICQUO047985 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 19 Oct 2020 21:12:29 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 09JICQUO047985 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 09JICQG9047984; Mon, 19 Oct 2020 21:12:26 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 19 Oct 2020 21:12:26 +0300 From: Konstantin Belousov To: John Baldwin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r366843 - head/sys/i386/i386 Message-ID: <20201019181226.GF2643@kib.kiev.ua> References: <202010191735.09JHZkqr067067@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202010191735.09JHZkqr067067@repo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4CFPxG44DNz3yWv X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2020 18:12:35 -0000 On Mon, Oct 19, 2020 at 05:35:46PM +0000, John Baldwin wrote: > Author: jhb > Date: Mon Oct 19 17:35:45 2020 > New Revision: 366843 > URL: https://svnweb.freebsd.org/changeset/base/366843 > > Log: > Properly clear PCB_KERNNPX in fpu_kern_leave(). > > PR: 250423 > Reported by: CI > Tested by: lwhsu > > Modified: > head/sys/i386/i386/npx.c > > Modified: head/sys/i386/i386/npx.c > ============================================================================== > --- head/sys/i386/i386/npx.c Mon Oct 19 17:07:19 2020 (r366842) > +++ head/sys/i386/i386/npx.c Mon Oct 19 17:35:45 2020 (r366843) > @@ -1475,7 +1475,7 @@ fpu_kern_leave(struct thread *td, struct fpu_kern_ctx > if ((pcb->pcb_flags & PCB_NPXUSERINITDONE) != 0) { > pcb->pcb_flags |= PCB_NPXINITDONE; > if ((pcb->pcb_flags & PCB_KERNNPX_THR) == 0) > - pcb->pcb_flags |= ~PCB_KERNNPX; > + pcb->pcb_flags &= ~PCB_KERNNPX; > } else if ((pcb->pcb_flags & PCB_KERNNPX_THR) == 0) > pcb->pcb_flags &= ~(PCB_NPXINITDONE | PCB_KERNNPX); > } else { My bad, thank you for fixing this.