Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Oct 2020 21:12:26 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r366843 - head/sys/i386/i386
Message-ID:  <20201019181226.GF2643@kib.kiev.ua>
In-Reply-To: <202010191735.09JHZkqr067067@repo.freebsd.org>
References:  <202010191735.09JHZkqr067067@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 19, 2020 at 05:35:46PM +0000, John Baldwin wrote:
> Author: jhb
> Date: Mon Oct 19 17:35:45 2020
> New Revision: 366843
> URL: https://svnweb.freebsd.org/changeset/base/366843
> 
> Log:
>   Properly clear PCB_KERNNPX in fpu_kern_leave().
>   
>   PR:		250423
>   Reported by:	CI
>   Tested by:	lwhsu
> 
> Modified:
>   head/sys/i386/i386/npx.c
> 
> Modified: head/sys/i386/i386/npx.c
> ==============================================================================
> --- head/sys/i386/i386/npx.c	Mon Oct 19 17:07:19 2020	(r366842)
> +++ head/sys/i386/i386/npx.c	Mon Oct 19 17:35:45 2020	(r366843)
> @@ -1475,7 +1475,7 @@ fpu_kern_leave(struct thread *td, struct fpu_kern_ctx 
>  		if ((pcb->pcb_flags & PCB_NPXUSERINITDONE) != 0) {
>  			pcb->pcb_flags |= PCB_NPXINITDONE;
>  			if ((pcb->pcb_flags & PCB_KERNNPX_THR) == 0)
> -				pcb->pcb_flags |= ~PCB_KERNNPX;
> +				pcb->pcb_flags &= ~PCB_KERNNPX;
>  		} else if ((pcb->pcb_flags & PCB_KERNNPX_THR) == 0)
>  			pcb->pcb_flags &= ~(PCB_NPXINITDONE | PCB_KERNNPX);
>  	} else {
My bad, thank you for fixing this.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201019181226.GF2643>