From owner-svn-src-user@freebsd.org Sat Mar 24 03:13:22 2018 Return-Path: Delivered-To: svn-src-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EAA3FF655A4 for ; Sat, 24 Mar 2018 03:13:21 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io0-f180.google.com (mail-io0-f180.google.com [209.85.223.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E4867442C; Sat, 24 Mar 2018 03:13:21 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io0-f180.google.com with SMTP id e7so17344617iof.2; Fri, 23 Mar 2018 20:13:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=GQOkxpVYkSbPXZdAy2HmKqrqOPC+47ddoEqV+cR7ZVE=; b=RBHTNpQV+/yz+ZxdwfdusxBfruBqSkmb8ykx96lq83/S4v8WO9RwLWpmCePLVo0Yl1 Hns5nd5NCVmdLnWQMKyyE+zdXR8ArxpJVf+NpTJ16Mw385NFH1Aq/+blOeSc/l8c7m3N bhSjryoV7/ALeQzPdMt4tcn6fChrXk69LEM847R9J1yOXhDneuPHcJskh1WZZq/I+KV5 cFb3wgLpmvjotGKepazt6Jgk47JlX1MgTBzkMvRlEZ/QgYJoisM7derrmMizUM6Rwj5B Ta9LQROxOWD+iNZwlqAAetgW+QHwsz89mSIRTc1fTU7bW0Tt722MlWstDqyEXUOEOKkw 7ENg== X-Gm-Message-State: AElRT7FTcF5/95Ytp+RiFL7bJw6F7JHEBteKC4/vFTFea13avLRJqk8a pZFEO3TaDRaXXT1mqnNecR5kbujZ X-Google-Smtp-Source: AG47ELsaZ0PX0GejtDlDbvo7icMZjZA1hPKMaQcwQpaVfY9fuHw3PDRuknaANLCo0+LLZ5EL3aDaTA== X-Received: by 10.107.135.82 with SMTP id j79mr28680003iod.14.1521860794590; Fri, 23 Mar 2018 20:06:34 -0700 (PDT) Received: from mail-io0-f174.google.com (mail-io0-f174.google.com. [209.85.223.174]) by smtp.gmail.com with ESMTPSA id i94sm7104235ioo.46.2018.03.23.20.06.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Mar 2018 20:06:34 -0700 (PDT) Received: by mail-io0-f174.google.com with SMTP id l3so17327039iog.0; Fri, 23 Mar 2018 20:06:34 -0700 (PDT) X-Received: by 10.107.70.18 with SMTP id t18mr17013135ioa.220.1521860794310; Fri, 23 Mar 2018 20:06:34 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.62.19 with HTTP; Fri, 23 Mar 2018 20:06:33 -0700 (PDT) In-Reply-To: <201803240246.w2O2kZnB033985@pdx.rh.CN85.dnsmgr.net> References: <201803232029.w2NKTYoA022545@repo.freebsd.org> <201803240246.w2O2kZnB033985@pdx.rh.CN85.dnsmgr.net> From: Conrad Meyer Date: Fri, 23 Mar 2018 20:06:33 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r331461 - in user/markj/netdump/sys: kern netinet/netdump sys vm To: "Rodney W. Grimes" Cc: src-committers , svn-src-user@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2018 03:13:22 -0000 The code review link is https://reviewboard.west.isilon.com/r/67553/ . It won't do you much good outside our corporate network, though. Here's a summary of the my feedback, which are pretty straightforward style-y cleanups and could easily be read out of the diff itself: 1. Move external function declarations from two .c files to a header (sys/mbuf.h). 2. Annotate unused parameters with __unused. 3. Replace unused M_FOO flags with 0 in mb_ctor_clust() invocation. Since valid M_FOO values are non-zero, this should result in an assertion if the APIs suddenly start using the passed flag value. 4. Add an assertion that mutually exclusive flags to zone_ctor (NOBUCKET | MAXBUCKET) are indeed mutually exclusive (NOBUCKET is new to this branch). The only change that isn't related to my feedback was: Drop trashing netdump mbufs during zone import subroutine. There are some further review comments which may eventually end up in this branch. Conrad On Fri, Mar 23, 2018 at 7:46 PM, Rodney W. Grimes wrote: >> Author: markj >> Date: Fri Mar 23 20:29:34 2018 >> New Revision: 331461 >> URL: https://svnweb.freebsd.org/changeset/base/331461 >> >> Log: >> Address some but not all review feedback from cem. > > Please be detailed in what is changing, as the above > only tells us where it came from in a vague way as > no review number is even cited. > > I know this is on a private branch, but when/if it > is merged this becomes part of the main line.