From owner-svn-src-head@FreeBSD.ORG  Sun Mar 22 08:37:03 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4C9671065670;
	Sun, 22 Mar 2009 08:37:03 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 06EFE8FC12;
	Sun, 22 Mar 2009 08:37:01 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id KAA02135;
	Sun, 22 Mar 2009 10:36:31 +0200 (EET) (envelope-from avg@freebsd.org)
Received: from localhost.topspin.kiev.ua ([127.0.0.1] helo=edge.pp.kiev.ua)
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1LlJAV-000AZX-3O; Sun, 22 Mar 2009 10:36:31 +0200
Message-ID: <49C5F88C.3070600@freebsd.org>
Date: Sun, 22 Mar 2009 10:36:28 +0200
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Thunderbird 2.0.0.19 (X11/20090114)
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <49C4C974.5050209@gmx.de>	<20090321130332.GD67783@alchemy.franken.de>	<49C5737F.1050902@gmx.de>
	<20090321.175756.-434257642.imp@bsdimp.com>
In-Reply-To: <20090321.175756.-434257642.imp@bsdimp.com>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, christoph.mallon@gmx.de,
	src-committers@freebsd.org, marius@alchemy.franken.de
Subject: Re: svn commit: r190098 - in head/sys/sparc64: fhc sparc64
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 22 Mar 2009 08:37:03 -0000

on 22/03/2009 01:57 M. Warner Losh said the following:
> I'll point out that style(9) doesn't say use as few local variables as
> possible...  That part is completely unspecified.

But it does say:
Do not put declarations inside blocks unless the routine is unusually
complicated.

"unusually complicated" is, of course, a very subjective measure.
But still this guideline contradicts typical guidelines for C and its
offspring which name we do not say to declare variables as close to
their first usage as possible.

E.g. you can have a simple 3 line block where you need a local variable
but that block is located 50 lines from start of an enclosing function.
Very convenient when you need to quickly glance the variable's type (not).

So add me to the count of people who has problem with this rule.

P.S.
And 80 symbol line rule (which is not even in style) is also not
justified in modern times, if you'll ask me :)

-- 
Andriy Gapon