Date: Tue, 12 Jul 2011 17:40:14 -0600 (MDT) From: Warren Block <wblock@wonkity.com> To: Jung-uk Kim <jkim@freebsd.org> Cc: Pav Lucistnik <pav@freebsd.org>, Stephen Montgomery-Smith <stephen@freebsd.org>, freebsd-ports@freebsd.org Subject: Re: [RFC] A trivial change for DESKTOP_ENTRIES Message-ID: <alpine.BSF.2.00.1107121731190.40818@wonkity.com> In-Reply-To: <201107121826.00020.jkim@FreeBSD.org> References: <201107121826.00020.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 12 Jul 2011, Jung-uk Kim wrote: > After I updated x11-wm/compiz, GNOME was not able to start the window > manager. Basically, it complained that compiz-manager was not found. > Then, I realized compiz-manager.desktop was automagically replaced by > compizmanager.desktop. Now I tracked it down to this commit: > > Sat Nov 27 17:42:46 2010 UTC (7 months, 2 weeks ago) by pav > > - DESKTOP_ENTRIES: commandline is used to name installed .desktop > file, this can lead to files containing whitespace and funny > characters; thus strip all non-alphanumeric characters > > http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk.diff?r1=1.656;r2=1.657 My fault, arising out of http://www.freebsd.org/cgi/query-pr.cgi?pr=147701 Additionally allowing dashes and underlines seems harmless. Spaces and disallowed characters like slashes were the original concern.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.1107121731190.40818>