From owner-svn-src-head@FreeBSD.ORG  Wed Dec 31 10:06:41 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A36DE106566C;
	Wed, 31 Dec 2008 10:06:41 +0000 (UTC) (envelope-from rik@inse.ru)
Received: from mail.inse.ru (mail.inse.ru [144.206.128.1])
	by mx1.freebsd.org (Postfix) with ESMTP id 5A1888FC0C;
	Wed, 31 Dec 2008 10:06:41 +0000 (UTC) (envelope-from rik@inse.ru)
Received: from www.inse.ru (www.inse.ru [144.206.128.1])
	by mail.inse.ru (Postfix) with ESMTPSA id F259933C51;
	Wed, 31 Dec 2008 12:49:36 +0300 (MSK)
Message-ID: <495B406F.2040305@localhost.inse.ru>
Date: Wed, 31 Dec 2008 12:50:39 +0300
From: Roman Kurakin <rik@inse.ru>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <200812271522.mBRFMMHY074982@svn.freebsd.org>
	<20081229.114241.756909212.imp@bsdimp.com>
In-Reply-To: <20081229.114241.756909212.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: rik@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r186520 - head/sys/dev/puc
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Dec 2008 10:06:42 -0000

M. Warner Losh wrote:
> In message: <200812271522.mBRFMMHY074982@svn.freebsd.org>
>             Roman Kurakin <rik@FreeBSD.org> writes:
> : Author: rik
> : Date: Sat Dec 27 15:22:22 2008
> : New Revision: 186520
> : URL: http://svn.freebsd.org/changeset/base/186520
> : 
> : Log:
> :   Add support for the Oxford OX16PCI958-based card.
> :   
> :   Note, that the patch provided with this card for the Linux states that
> :   the card uses DEFAULT_RCLK * 2, while in fact it is '* 10'.  So probably
> :   we should also use the subdevice/subvendord here. For now just ignore
> :   that fact.
>
> I've had problems with doing that on some Oxford based cards.  The
> vendor that uses them doesn't set them up, so you can't tell my
> cardbus oxford card from the pcie oxford card that someone else sent
> me patches for: both with different clock multipliers...
>   
Probably we need to implement AUTODETECT_RCLK. I've had the patch,
but it worked only for modules, cause there was no working timers while the
cards probe time if the driver was compiled in. I've planned to move 
detection
code to the first open and do some cleanup after the detection, but 
didn't do
that.

rik
> Warner
>