From owner-freebsd-net@FreeBSD.ORG Mon Mar 31 08:13:45 2003 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 521CC37B401 for ; Mon, 31 Mar 2003 08:13:45 -0800 (PST) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8D4343F93 for ; Mon, 31 Mar 2003 08:13:44 -0800 (PST) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.8/8.12.3) with ESMTP id h2VGDWLA019545; Mon, 31 Mar 2003 08:13:32 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.8/8.12.3/Submit) id h2VGDWZc019544; Mon, 31 Mar 2003 08:13:32 -0800 Date: Mon, 31 Mar 2003 08:13:32 -0800 From: Brooks Davis To: "M. Warner Losh" Message-ID: <20030331081331.A27067@Odin.AC.HMC.Edu> References: <20030329.195108.133248709.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="fUYQa+Pmc3FrFX/N" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20030329.195108.133248709.imp@bsdimp.com>; from imp@bsdimp.com on Sat, Mar 29, 2003 at 07:51:08PM -0700 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu cc: net@freebsd.org Subject: Re: ifconfig question X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2003 16:13:46 -0000 --fUYQa+Pmc3FrFX/N Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 29, 2003 at 07:51:08PM -0700, M. Warner Losh wrote: > The code that prints out the keys for the 802.11 wireless stuff has > the following it it: >=20 > void > ieee80211_status (int s, struct rt_addrinfo *info __unused) > { > ... > if (ireq.i_len =3D=3D 0 || ireq.i_len > 13) > continue; > ... > } >=20 > Should that check really be there? Newer wep does 256bits.... Not > that the rest of the code supports that, but I was just curious. It could probably be safely removed. > Second, should ifconfig report the wep key if run as root? wicontrol > does if it is run as root, for example. Any objections for fixing > this? That seems reasonable. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --fUYQa+Pmc3FrFX/N Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+iGkqXY6L6fI4GtQRAjhnAJ45/rc47RVaIUuNJoaxyEx9GDnhtQCfQn2g LWsSzP/qIEY5sfyj1ixcQnk= =dJOD -----END PGP SIGNATURE----- --fUYQa+Pmc3FrFX/N--