From owner-freebsd-current Mon Jul 1 12:30:46 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AABCA37B400 for ; Mon, 1 Jul 2002 12:30:44 -0700 (PDT) Received: from mail.inka.de (quechua.inka.de [212.227.14.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4399043E26 for ; Mon, 1 Jul 2002 12:30:43 -0700 (PDT) (envelope-from mailnull@mips.inka.de) Received: from kemoauc.mips.inka.de (uucp@) by mail.inka.de with local-bsmtp id 17P6sk-0003Fl-00; Mon, 1 Jul 2002 21:30:42 +0200 Received: from kemoauc.mips.inka.de (localhost [127.0.0.1]) by kemoauc.mips.inka.de (8.12.5/8.12.5) with ESMTP id g61IonoU013387 for ; Mon, 1 Jul 2002 20:50:49 +0200 (CEST) (envelope-from mailnull@localhost.mips.inka.de) Received: (from mailnull@localhost) by kemoauc.mips.inka.de (8.12.5/8.12.5/Submit) id g61IomHx013386 for freebsd-current@freebsd.org; Mon, 1 Jul 2002 20:50:48 +0200 (CEST) From: naddy@mips.inka.de (Christian Weisgerber) Subject: Re: LP64: (int)signal() Date: Mon, 1 Jul 2002 18:50:48 +0000 (UTC) Message-ID: References: <20020701111919.B20124@espresso.q9media.com> Originator: naddy@mips.inka.de (Christian Weisgerber) To: freebsd-current@freebsd.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Mike Barcroft wrote: > You might want to get rid of the other misuse of `rc' above this and > just remove the variable. The use of an gratuitous int variable rc to capture return values is rampant throughout this code. In fact, not using it is something of a violation of the local style, but in the case of signal() I think it's justifiable because SIG_ERR is so much neater than changing rc to long and messing around with explicit casts. -- Christian "naddy" Weisgerber naddy@mips.inka.de To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message