From owner-p4-projects@FreeBSD.ORG  Sun Apr 27 13:36:46 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E9BE337B404; Sun, 27 Apr 2003 13:36:45 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 81A0A37B401
	for <perforce@freebsd.org>; Sun, 27 Apr 2003 13:36:45 -0700 (PDT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2B13243F85
	for <perforce@freebsd.org>; Sun, 27 Apr 2003 13:36:45 -0700 (PDT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h3RKai0U075283
	for <perforce@freebsd.org>; Sun, 27 Apr 2003 13:36:44 -0700 (PDT)
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h3RKai2j075274
	for perforce@freebsd.org; Sun, 27 Apr 2003 13:36:44 -0700 (PDT)
Date: Sun, 27 Apr 2003 13:36:44 -0700 (PDT)
Message-Id: <200304272036.h3RKai2j075274@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 29892 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Apr 2003 20:36:47 -0000

http://perforce.freebsd.org/chv.cgi?CH=29892

Change 29892 by marcel@marcel_pluto2 on 2003/04/27 13:36:37

	Step 1: Properly announce a constant timer as a bad timer. A
		constant timer is one that is both monotonically
		increasing and monotonically decreasing at the same
		time.
	
	This fixes the announcement on the HP rx2600 where we basicly
	read a bogus register due to not properly using the v2 ACPI
	tables and invariable read the same value. We were quite happy
	with this even if it made time stop completely when booting a
	SMP kernel. The 100% CPU usage for ntpd in an attempt to make
	time advance didn't make us unhappy. Except Kerberos: the time
	skew prevented logging in...
	
	Step 2 is to fix getting the ACPI timer info from the tables.
	This is in progress...

Affected files ...

.. //depot/projects/ia64/sys/dev/acpica/acpi_timer.c#9 edit

Differences ...

==== //depot/projects/ia64/sys/dev/acpica/acpi_timer.c#9 (text+ko) ====

@@ -129,14 +129,14 @@
 	}
 	if (max - min > 2)
 		n = 0;
-	else if (min < 0)
+	else if (min < 0 || max == 0)
 		n = 0;
 	else
 		n = 1;
 	if (bootverbose)
 		printf("ACPI timer looks %s min = %d, max = %d, width = %d\n",
 			n ? "GOOD" : "BAD ",
-			min, max, max - min + 1);
+			min, max, max - min);
 	return (n);
 }