From owner-svn-ports-all@freebsd.org Sat May 21 19:34:49 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6514FB44F8A; Sat, 21 May 2016 19:34:49 +0000 (UTC) (envelope-from duchateau.olivier@gmail.com) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DC0E51D2F; Sat, 21 May 2016 19:34:48 +0000 (UTC) (envelope-from duchateau.olivier@gmail.com) Received: by mail-wm0-x231.google.com with SMTP id n129so24563455wmn.1; Sat, 21 May 2016 12:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gNjzvZhPil0WRAJARTO801NRNweRepfBy6g9ZDTWQMo=; b=Rd2hck2fTmIBPXJI36vspBBZVTTWD/r2xoH9PYpbWVaiJzAhJwAnzC2OFRhPancXgY TM1hJ4GAdWLsBJ5gcKIlDC/8IC1EFbdKYk2+89m5y2vRdfn3Kf/kUxTneguoxQzLhjNu P9JwxIHL/a0BIsr6bqQOIt2y/4xISTdcrAyuAjdpnEJyR1HPGdVIE0x3ZccE9MLfwzCP 9/DlPyNZquGVG3n/tv45ahIpBUSuN/NCV6A28qhPSkkm6ymbB0ESHGhcKUQ809ycy5Ys /fo8N2BixwRCzgg7CK88njXkW0rYlVWOlafC684Ad+uAqg4OkhQHpMkJJxkBZVbWho+s FCrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=gNjzvZhPil0WRAJARTO801NRNweRepfBy6g9ZDTWQMo=; b=lgl8/CNjFLNYvI9BwLkkg8NYmWcwVlvKPXfYNTBXkb7rhmGt+L371cWdAM7WuitU+5 Kuz6+fCOI60f85arLEDJ8e0h8e72o3bEwbhsfHMd08FfA7dCU5QR7iyDsyKcY4na/FsG +7GxJtLz0/N5so/5i/t3JX+Z0xb2HnZNz2lSwvHoB1WfJNhmSIHkWZFiKWet69XFz4o1 hg337eTvkM7PBYX6hQBFdK3Ym9rgVln1rBxxXYwKBq7Dnz6qn1LUZAj3TmOVDAUmENm7 8G2I2RGyUOa3DWHIZ2C15fnYpYXsFf1pU0stV/mgQfIRe1oaSi5a0Vbqzuzx7nR99jn0 jNcw== X-Gm-Message-State: AOPr4FUe53z5D/JfPRmrnxqa+EsueDnFelsX94eD0mnkf6rIWO4lqnJDNKWDuK9blnsZMQ== X-Received: by 10.28.210.72 with SMTP id j69mr9946326wmg.12.1463859287487; Sat, 21 May 2016 12:34:47 -0700 (PDT) Received: from tuborg (AMarseille-655-1-577-169.w86-210.abo.wanadoo.fr. [86.210.186.169]) by smtp.gmail.com with ESMTPSA id n66sm4731877wmf.6.2016.05.21.12.34.45 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 May 2016 12:34:46 -0700 (PDT) Sender: Olivier Duchateau Date: Sat, 21 May 2016 21:32:31 +0000 From: Olivier Duchateau To: Baptiste Daroussin Cc: Alexey Dokuchaev , Adam Weinberger , marino@freebsd.org, Ed Maste , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r415078 - in head: . Mk Message-Id: <20160521213231.7ce1b88755748e7996e55cc9@freebsd.org> In-Reply-To: <20160521183643.GL21899@ivaldir.etoilebsd.net> References: <20160513201919.GA48945@FreeBSD.org> <20160519122306.GA24015@FreeBSD.org> <20160521112728.GA624@FreeBSD.org> <364d3d9f-63ff-18c8-c730-a11c57dc0673@marino.st> <20160521114358.GC624@FreeBSD.org> <20160521122522.GJ21899@ivaldir.etoilebsd.net> <20160521162931.GA97771@FreeBSD.org> <43145C09-EC33-4738-9FE7-5DC34A74D64B@adamw.org> <20160521183507.GB96389@FreeBSD.org> <20160521183643.GL21899@ivaldir.etoilebsd.net> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.29; i386-portbld-freebsd9.3) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 May 2016 19:34:49 -0000 On Sat, 21 May 2016 20:36:43 +0200 Baptiste Daroussin wrote: > On Sat, May 21, 2016 at 06:35:07PM +0000, Alexey Dokuchaev wrote: > > On Sat, May 21, 2016 at 11:11:12AM -0600, Adam Weinberger wrote: > > > > On 21 May, 2016, at 10:29, Alexey Dokuchaev wrote: > > > > On Sat, May 21, 2016 at 02:25:22PM +0200, Baptiste Daroussin wrote: > > > >> Implementing it as a Makefile variable would make it not automatically > > > >> updated. > > > > > > > > Even if we can agree on REP_TIMESTAMP variable, why `make makesum' cannot > > > > sed -i the Makefile? > > > > > > Oh god, please, no. Please do not mess with Makefiles. > > > > > > Rather than having it come from 'makesum', can an svn hook write it to > > > distinfo? May help it stay more current. > > > > I understand your worries, but SVN already messes with Makefiles (keywords). > > On the other hand, adding $Id$ to distinfo would both 1) solve the problem, > > at least as I see it now, and 2) won't mix data with metadata which is I'm > > debating against. > > > > Baptiste, was adding $Id$ to distinfo considered/tested? If yes, why was it > > rejected? > > > It won't work because keywords are not expanded in git and hg (and yes we do > officially support our git mirror) About Mercurial (hg), it supports keywords too. It's even an official extension. > > Best regards, > Bapt -- Olivier Duchateau