From owner-freebsd-hackers@FreeBSD.ORG Sat Jun 7 11:18:47 2008 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E0E971065676; Sat, 7 Jun 2008 11:18:47 +0000 (UTC) (envelope-from lulf@stud.ntnu.no) Received: from bene2.itea.ntnu.no (bene2.itea.ntnu.no [IPv6:2001:700:300:3::57]) by mx1.freebsd.org (Postfix) with ESMTP id 241F28FC13; Sat, 7 Jun 2008 11:18:46 +0000 (UTC) (envelope-from lulf@stud.ntnu.no) Received: from localhost (localhost [127.0.0.1]) by bene2.itea.ntnu.no (Postfix) with ESMTP id 4133C90004; Sat, 7 Jun 2008 13:18:45 +0200 (CEST) Received: from carrot.studby.ntnu.no (unknown [IPv6:2001:700:300:3::184]) by bene2.itea.ntnu.no (Postfix) with ESMTP id 9BF7590003; Sat, 7 Jun 2008 13:18:44 +0200 (CEST) Date: Sat, 7 Jun 2008 13:19:28 +0200 From: Ulf Lilleengen To: Kris Kennaway Message-ID: <20080607111837.GA1840@carrot.studby.ntnu.no> References: <20080531143655.GA14020@nobby.studby.ntnu.no> <484A443D.8080900@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <484A443D.8080900@FreeBSD.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-Virus-Scanned: Debian amavisd-new at bene2.itea.ntnu.no Cc: freebsd-hackers@freebsd.org, freebsd-current@freebsd.org Subject: Re: CFT: CVSMode for csup with MD5 check X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jun 2008 11:18:48 -0000 On lør, jun 07, 2008 at 10:18:05am +0200, Kris Kennaway wrote: > Ulf Lilleengen wrote: > > Hello, > > > > As a followup to my previous patch on csup, I've tried to do some fixes to > > RCS-files. However, instead of doing major workarounds in csup to handle > > files which does not behave correctly to RCS, I implemented MD5 check of RCS > > content. This means that the MD5 sum from cvsupd is checked against the > > actual RCS content (which is different from a normal MD5 check, because > > only the content is compared), and if it's not correct, a fixup of the file > > will be sent, thus making sure that the contents are correct. I hope some of > > you are able to test this. > > > > There are still a few issues with cvsmode: > > - Not correct entries in status file. > > - I get unnatural high memory usage. > > > > Patches here: > > http://people.freebsd.org/~lulf/patches/csup/csup_2008-05-31_CURRENT.diff > > and > > http://people.freebsd.org/~lulf/patches/csup/csup_2008-05-31_RELENG_7.diff > > > > This doesn't compile. There are a bunch of warnings, and rcsfile.c is > missing from Makefile, but there is an undefined reference: > > rcsfile.o(.text+0x1d32): In function `rcsfile_frompath': > : undefined reference to `rcsparse_run' > *** Error code 1 > Sorry, I probably didn't test the patch correctly. These patches now works for me on a 7.0 and CURRENT tree at least: http://people.freebsd.org/~lulf/patches/csup/csup_2008-06-07_RELENG_7.diff http://people.freebsd.org/~lulf/patches/csup/csup_2008-06-07_CURRENT.diff -- Ulf Lilleengen