From owner-freebsd-bugs@freebsd.org Tue Feb 19 17:12:35 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FC3C14F5DB1 for ; Tue, 19 Feb 2019 17:12:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0F2368E865 for ; Tue, 19 Feb 2019 17:12:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id BEB6014F5DB0; Tue, 19 Feb 2019 17:12:34 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 95EB014F5DAF for ; Tue, 19 Feb 2019 17:12:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 24F168E861 for ; Tue, 19 Feb 2019 17:12:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 6E2292CF2 for ; Tue, 19 Feb 2019 17:12:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x1JHCXBp005033 for ; Tue, 19 Feb 2019 17:12:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x1JHCXkv005032 for bugs@FreeBSD.org; Tue, 19 Feb 2019 17:12:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 235863] file loss when adding faulty entry in a jail's /etc/fstab.foo after removing jail Date: Tue, 19 Feb 2019 17:12:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: unixmig68@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2019 17:12:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235863 Bug ID: 235863 Summary: file loss when adding faulty entry in a jail's /etc/fstab.foo after removing jail Product: Base System Version: 11.2-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: unixmig68@gmail.com FreeBSD 11.2-RELEASE, *based on mfsbsd, *not* tested on *vanilla* FreeBSD 11.2-RELEASE*. Files are lost when the following steps are made: Start a jail foo, edit its /etc/fstab.foo, adding a nullfs-rw mount that is not valid (e.g. non-existent mountpoint), jail -r jail foo When you remove the jail, you get an error because of the wrong entry. The main mountpoint of the jail is now still mounted. When you manually umount this remaining main mountpoint, all nullfs-rw mount files are lost. Expected result: files would not be lost Actual result: files are lost Example: # cat /etc/fstab.maygo /usr/jail/basejail /usr/jail/foo nullfs = ro /zroot/j/foo.d/foo.homedir /usr/jail/foo/usr/home nullfs rw /zroot/j/foo.d/foo.var /usr/jail/foo/var nullfs rw /zroot/j/foo.d/foo.tmp /usr/jail/foo/tmp nullfs rw /zroot/j/foo.d/foo.etc /usr/jail/foo/etc nullfs rw /zroot/j/foo.d/foo.root /usr/jail/foo/root nullfs rw # --------------------------- # cat /etc/jail.conf # Common configs for all jails mount.fstab =3D "/etc/fstab.${name}"; exec.start =3D "/bin/sh /etc/rc"; exec.stop =3D "/bin/sh /etc/rc.shutdown"; exec.consolelog =3D "/var/log/jail_${name}_console.log"; host.hostname =3D "${name}"; allow.mount; devfs_ruleset =3D "4"; mount.devfs; allow.set_hostname =3D 0; path =3D "/usr/jail/${name}"; foo { ip4.addr =3D 10.2.2.4 ; interface =3D vtnet0; allow.sysvipc =3D 1; allow.raw_sockets =3D 1; persist; } # ----------------------------- # jls JID IP Address Hostname Path # jail -c foo foo: created # find /zroot/j/foo.d | wc 100 100 3971 # jls JID IP Address Hostname Path 46 10.2.2.4 foo /usr/jail/foo # echo "/zroot/j/foo.d/foo.root /usr/jail/foo/NONEXISTENTDIR=20=20= =20=20=20=20=20=20 nullfs rw" >> /etc/fstab.foo # tail -3 /etc/fstab.foo /zroot/j/foo.d/foo.root /usr/jail/foo/root nullfs rw /zroot/j/foo.d/foo.root /usr/jail/foo/NONEXISTENTDIR nullf= s=20 rw # jail -r foo foo: removed jail: foo: mount.fstab: /usr/jail/foo/NONEXISTENTDIR: No such file or direc= tory # mount | grep foo zroot/j/foo.d on /zroot/j/foo.d (zfs, local, noatime, nfsv4acls) # umount /zroot/j/foo.d # echo $? 0 # find /zroot/j/foo.d | wc 1 1 17 # zfs list | grep foo zroot/j/foo.d 34.0M 8.50G 34.0M /zroot/j/foo.d # zfs get mountpoint zroot/j/foo.d NAME PROPERTY VALUE SOURCE zroot/j/foo.d mountpoint /zroot/j/foo.d inherited from zroot # mount zroot/j/foo.d /zroot/j/foo.d mount: zroot/j/foo.d: No such file or directory --=20 You are receiving this mail because: You are the assignee for the bug.=