Date: Sat, 21 Mar 2015 15:05:43 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Dirk Meyer <dinoex@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r381789 - in head/security/openssl: . files Message-ID: <20150321150543.GC55163@FreeBSD.org> In-Reply-To: <1AEB8BFF81EB37117B9DC39E@atuin.in.mat.cc> References: <201503211053.t2LArEMw041053@svn.freebsd.org> <C91A13C9C4702AD75CF332CB@atuin.in.mat.cc> <20150321144244.GA55163@FreeBSD.org> <1AEB8BFF81EB37117B9DC39E@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 21, 2015 at 03:50:16PM +0100, Mathieu Arnold wrote: > +--On 21 mars 2015 14:42:44 +0000 Alexey Dokuchaev <danfe@FreeBSD.org> > wrote: > | On Sat, Mar 21, 2015 at 02:15:52PM +0100, Mathieu Arnold wrote: > |> +--On 21 mars 2015 10:53:14 +0000 Dirk Meyer <dinoex@FreeBSD.org> wrote: > |> | PORTNAME= openssl > |> | -PORTVERSION= 1.0.1 > |> | -DISTVERSIONSUFFIX= m > |> | -PORTREVISION= 19 > |> | +PORTVERSION= 1.0.2 > |> | +DISTVERSIONSUFFIX= a > |> | +PORTREVISION= 0 > |> > |> Would you consider setting PORTVERSION=1.0.2a and dropping > |> DISTVERSIONSUFFIX ? It is mostly confusing to not have the openssl > |> package have the real version all the time. > | > | Except that is should probably be DISTVERSION, not PORTVERSION in this > | case, to make it more "monotonic versions" friendly. > > I'm not sure exactly what it would achieve, save, maybe not put the right > version number where it should be. > > $ pkg version -t 1.0.2 1.0.2a > < > $ pkg version -t 1.0.2a 1.0.2b > < > $ pkg version -t 1.0.2b 1.0.2c > < > $ pkg version -t 1.0.2d 1.0.2c Hmm, perhaps in this case (OpenSSL) PORTVERSION in indeed correct choice, sorry for the noise. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150321150543.GC55163>