From owner-freebsd-arch@FreeBSD.ORG Wed Jun 10 00:03:51 2009 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5ADC106566B for ; Wed, 10 Jun 2009 00:03:51 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from alto.onthenet.com.au (alto.OntheNet.com.au [203.13.68.12]) by mx1.freebsd.org (Postfix) with ESMTP id 86FC88FC12 for ; Wed, 10 Jun 2009 00:03:51 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au [203.13.70.57]) by alto.onthenet.com.au (Postfix) with ESMTP id B5FBA11A56; Wed, 10 Jun 2009 09:48:25 +1000 (EST) Received: from peter-grehans-macbook.local (c-76-25-181-67.hsd1.co.comcast.net [76.25.181.67]) by dommail.onthenet.com.au (MOS 3.8.6-GA) with ESMTP id EUR41149 (AUTH peterg@ptree32.com.au); Wed, 10 Jun 2009 09:48:24 +1000 (EST) Message-ID: <4A2EF4C4.408@freebsd.org> Date: Tue, 09 Jun 2009 17:48:20 -0600 From: Peter Grehan User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302) MIME-Version: 1.0 To: "M. Warner Losh" References: <20090609.174249.-1435625969.imp@bsdimp.com> In-Reply-To: <20090609.174249.-1435625969.imp@bsdimp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: arch@freebsd.org Subject: Re: devclass_find_free_unit X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2009 00:03:52 -0000 Hi Warner, > What purpose does devclass_find_free_unit serve? I think it can safely be > eliminated from the tree. The current design is racy. ... > ./powerpc/psim/.svn/text-base/ata_iobus.c That would be a cut'n'paste relic from the ATA code that it originated from. Going to -1 is fine. later, Peter.