From owner-cvs-all@FreeBSD.ORG Sun Dec 31 18:03:48 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9043C16A403 for ; Sun, 31 Dec 2006 18:03:48 +0000 (UTC) (envelope-from alepulver@FreeBSD.org) Received: from relay03.pair.com (relay03.pair.com [209.68.5.17]) by mx1.freebsd.org (Postfix) with SMTP id 5026313C469 for ; Sun, 31 Dec 2006 18:03:47 +0000 (UTC) (envelope-from alepulver@FreeBSD.org) Received: (qmail 97986 invoked by uid 0); 31 Dec 2006 18:03:46 -0000 Received: from unknown (HELO phobos.mars.bsd) (unknown) by unknown with SMTP; 31 Dec 2006 18:03:46 -0000 X-pair-Authenticated: 200.115.252.195 Date: Sun, 31 Dec 2006 15:03:44 -0300 From: Alejandro Pulver To: pav@FreeBSD.org Message-ID: <20061231150344.25871955@phobos.mars.bsd> In-Reply-To: <1167584645.1320.33.camel@ikaros.oook.cz> References: <200612310434.kBV4YRXS037540@repoman.freebsd.org> <1167575429.1320.24.camel@ikaros.oook.cz> <20061231133753.4156b868@phobos.mars.bsd> <1167584645.1320.33.camel@ikaros.oook.cz> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.10.6; i386-portbld-freebsd6.1) Mime-Version: 1.0 Content-Type: multipart/signed; boundary=Sig_bHF_Ss9cipe+3tdn2jL0ky8; protocol="application/pgp-signature"; micalg=PGP-SHA1 Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.wx.mk X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Dec 2006 18:03:48 -0000 --Sig_bHF_Ss9cipe+3tdn2jL0ky8 Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable On Sun, 31 Dec 2006 18:04:05 +0100 Pav Lucistnik wrote: > Alejandro Pulver p=ED=B9e v ne 31. 12. 2006 v 13:37 -0300: > > On Sun, 31 Dec 2006 15:30:29 +0100 > > Pav Lucistnik wrote: > >=20 > > > > - Remove _WX_ILLEGAL_VERS_* added in the last update to 2.8. The = reason is > > > > that each port should choose the version it can use, that inclu= des taking > > > > into account available components (also this brings much more c= hicken and > > > > egg problems so the code could get really messy). > > >=20 > > > I have reverted this. It's needed as long as you want to let people u= se > > > ranges like 2.4+ together with python component, etc. > > >=20 > >=20 > > It is complex to do that (if you want to do it the right way), because > > you need to parse components and dependencies before selecting a > > version. The current code is wrong since it will only reject components > > without dependency type specifications (and if there were dependencies > > then it will also ignore them). > >=20 > > I think people should select the versions that actually work with the > > port, that's why the version specification string is so flexible. > >=20 > > Also, if versions with invalid components are removed then the reported > > error if a user writes USE_WX=3D2.4 and WX_COMPS=3Dsvg would be "select= ed a > > null or invalid WxWidgets version" instead of "selected a WxWidgets > > component (${_WX_COMP}) which is not available for the selected version > > (${_WX_VER})". >=20 > That can be done, I'm confident. >=20 Yes, but it will remove flexibility in some way: Currently the version is processed independently from the components. The first one is done in or in if WX_PREMK is defined (for ports like "x11-toolkits/py-wxPython26"). And the second one is always checked in . If I make the version to depend on the components, then when USE_PREMK is defined, the port won't be able to modify WX_COMPS after (because the components can alter the version, and if then the port will think it's using one, but other will be used). >=20 > But the problem is really this: > With a port allowing USE_WX=3D2.4+ and WX_COMPS=3Dpython, it should go for > 2.4 or 2.6, instead of selecting 2.8 and then failing. >=20 > I'm not happy with it setting such port on IGNORE. Why it should fail, > when perfectly legit option is available? It should bail out with IGNORE > when you select USE_WX=3D2.8 and WX_COMPS=3Dpython, never else. >=20 I also agree with this, but see the problem above. > > > Also, the auto-detection does not seem to work: > > >=20 [...] > >=20 > > Sorry, I re-wrote it many times and forgot this: > >=20 > > -_WX_VER_INSTALLED:=3D ${_HAVE_WX} > > +_WX_VER_INSTALLED:=3D ${_HAVE_WX:Mwx-*:S/wx-//} >=20 > Please commit this fix. >=20 Done. Best Regards, Ale --Sig_bHF_Ss9cipe+3tdn2jL0ky8 Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFl/uHiV05EpRcP2ERAlnXAJ9RjRXADkNcfzaJ7VbPdj7/QduATACgyp2Y dritpkneH1VSX0gS5XQwOPk= =7b+J -----END PGP SIGNATURE----- --Sig_bHF_Ss9cipe+3tdn2jL0ky8--