From owner-dev-commits-src-main@freebsd.org Tue Dec 29 17:52:11 2020 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A12AF4C6A56; Tue, 29 Dec 2020 17:52:11 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D526z42B5z4t25; Tue, 29 Dec 2020 17:52:11 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 7D4D12B8D5; Tue, 29 Dec 2020 17:52:11 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f174.google.com with SMTP id c7so12009416qke.1; Tue, 29 Dec 2020 09:52:11 -0800 (PST) X-Gm-Message-State: AOAM531jMRS7hlFhj3vqS6q/pfwfB/bHxCv2wwnhOSK0VdT1HqJk1HFf CtujEd3XhqMKMV+Ys6Bj+RQ+KtZZ+6iFCCsR2Vc= X-Google-Smtp-Source: ABdhPJxMbYFp6sSkgcFznEk7IIihWjEPKINuB0zR+MByIeS3+XJyC5cfWBMsKZVswF9nFL1urvD37uto9OOjf3qvr7s= X-Received: by 2002:a37:b442:: with SMTP id d63mr21569437qkf.430.1609264331076; Tue, 29 Dec 2020 09:52:11 -0800 (PST) MIME-Version: 1.0 References: <202012291739.0BTHd2ji001052@gitrepo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Tue, 29 Dec 2020 11:51:57 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: ee938b20335d - main - kern: efirt: correct configuration table entry size To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for the main branch of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2020 17:52:11 -0000 On Tue, Dec 29, 2020 at 11:48 AM Jessica Clarke wrote: > > On 29 Dec 2020, at 17:39, Kyle Evans wrote: > > diff --git a/sys/sys/efi.h b/sys/sys/efi.h > > index b9f31454efff..220509853cb2 100644 > > --- a/sys/sys/efi.h > > +++ b/sys/sys/efi.h > > @@ -52,7 +52,7 @@ typedef unsigned long efi_status; > > > > struct efi_cfgtbl { > > struct uuid ct_uuid; > > - uint64_t ct_data; > > + void *ct_data; > > Hm, this should probably be a u_long/vm_offset_t/vm_paddr_t (though the > tables are unlikely to be in places where you need PAE so even if > technically correct, vm_paddr_t probably just makes things more awkward > for no gain) given it's not a real pointer that can be dereferenced. > I don't really have strong feelings either way; I originally pushed it to void* to match edk2 because I was entertaining the thought of just using edk2's definitions instead anyways, but I got distracted and did not get back around to deciding if that was a reasonable idea or not.