From owner-svn-src-all@FreeBSD.ORG Thu Jun 25 13:43:56 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 100C9106568F; Thu, 25 Jun 2009 13:43:56 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121]) by mx1.freebsd.org (Postfix) with ESMTP id 13C768FC19; Thu, 25 Jun 2009 13:43:54 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from [212.86.226.226] (account mav@alkar.net HELO mavbook.mavhome.dp.ua) by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9) with ESMTPSA id 246816997; Thu, 25 Jun 2009 16:43:50 +0300 Message-ID: <4A437F11.6000708@FreeBSD.org> Date: Thu, 25 Jun 2009 16:43:45 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.21 (X11/20090405) MIME-Version: 1.0 To: Rafal Jaworowski References: <200906241538.n5OFcHwp018860@svn.freebsd.org> <4A434F2C.1020005@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, =?windows-1252?Q?Piotr_Zie=3Bcik?= Subject: Re: svn commit: r194844 - in head/sys: conf dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jun 2009 13:43:56 -0000 Rafal Jaworowski wrote: > On 2009-06-25, at 12:19, Alexander Motin wrote: >> Rafal Jaworowski wrote: >>> ===================================================================== >>> --- head/sys/conf/files Wed Jun 24 15:33:33 2009 (r194843) >>> +++ head/sys/conf/files Wed Jun 24 15:38:17 2009 (r194844) >>> @@ -491,12 +491,12 @@ dev/ata/ata_if.m optional ata | atacore >>> dev/ata/ata-all.c optional ata | atacore >>> dev/ata/ata-lowlevel.c optional ata | atacore >>> dev/ata/ata-queue.c optional ata | atacore >>> +dev/ata/ata-dma.c optional ata | atadma >>> +dev/ata/ata-sata.c optional ata | atasata >> >> What is atadma and atasata here, kernel options? What for are they >> needed? You will not be able to build most of drivers without them, >> while enabling them for others will not give you any benefit, just >> bigger code size. I think dependency must be reviewed there. > > This was supposed to follow the fine grained kernel options route for > various ata subsystems. Both ata-dma.c and ata-sata.c seem orthogonal to > the rest of the ata framework (think ata controller without DMA, which > is often seen in embedded). They could also be made mandatory under > atacore, I have no problem with this approach too. There is move for fine-grained PCI drivers modularization. But ata-dma.c and ata-sata.c are not a drivers and are not a kernel modules. They are not orthogonal, but mandatory requisites of some drivers (all PCI, plus may be some others). All kernel build dependencies must be tracked without user influence. So please, or, as you said, add them both to the atacore, or, as I would prefer, ata-dma.c to atapci and any other requiring drivers, and ata-sata.c to atacore. -- Alexander Motin