From owner-cvs-all@FreeBSD.ORG Mon Feb 18 14:20:31 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 624CB16A420; Mon, 18 Feb 2008 14:20:31 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97]) by mx1.freebsd.org (Postfix) with ESMTP id B7D4213C4EF; Mon, 18 Feb 2008 14:20:30 +0000 (UTC) (envelope-from yar@comp.chem.msu.su) Received: from comp.chem.msu.su (localhost [127.0.0.1]) by comp.chem.msu.su (8.13.4/8.13.4) with ESMTP id m1IEKFkF066415; Mon, 18 Feb 2008 17:20:15 +0300 (MSK) (envelope-from yar@comp.chem.msu.su) Received: (from yar@localhost) by comp.chem.msu.su (8.13.4/8.13.4/Submit) id m1IEKEHC066414; Mon, 18 Feb 2008 17:20:14 +0300 (MSK) (envelope-from yar) Date: Mon, 18 Feb 2008 17:20:14 +0300 From: Yar Tikhiy To: Craig Rodrigues Message-ID: <20080218142013.GH30694@comp.chem.msu.su> References: <200802181024.m1IAOmoF089632@repoman.freebsd.org> <20080218104846.GA81672@crodrigues.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080218104846.GA81672@crodrigues.org> User-Agent: Mutt/1.5.9i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/mount_nfs mount_nfs.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Feb 2008 14:20:31 -0000 On Mon, Feb 18, 2008 at 10:48:46AM +0000, Craig Rodrigues wrote: > On Mon, Feb 18, 2008 at 10:24:48AM +0000, Yar Tikhiy wrote: > > yar 2008-02-18 10:24:48 UTC > > > > FreeBSD src repository > > > > Modified files: > > sbin/mount_nfs mount_nfs.c > > Log: > > Add a work-around to make it possible again to remount > > NFS root r/w. > > This is really a horrible hack. If this hack is necessary > due to your 1.274 change to vfs_mount.c, can you back this This horrible hack is necessary because Someone(tm) started converting our NFS client to the new nmount(2) semantics a year ago but he has never finished the job. Now the NFS client just uses old mount(2) semantics over nmount(2) by stuffing all NFS-related options in "nfs_args" and passing the standard options as bit flags. At the same time, the kernel part of the NFS client already relies on string options instead of bit flags -- ever tried to remount a r/w NFS mount to read-only since nfs_vfsops.c #1.176? Hence the hack. > change and 1.274 to vfs_mount.c out, until we can analyze > the full implications of your change, and properly fix the > necessary infrastructure, instead of committing hack after hack? Which else _hacks_ did I commit? -- Yar