Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 4 May 2014 01:27:38 -0700
From:      Adrian Chadd <adrian@freebsd.org>
To:        Kevin Oberman <rkoberman@gmail.com>,  "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>,  "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org>
Subject:   proposal: set default lid state to S3, performance/economy Cx states to Cmax
Message-ID:  <CAJ-Vmo=mUtpjgVwNHg8af05vCxVchZdsaekR9_Wf-pOfFjnABQ@mail.gmail.com>

next in thread | raw e-mail | index | archive | help
Hi,

I'd like to propose flipping a few things:

* Flipping the default lid state to S3. I think ACPI suspend/resume
seems to work well enough these days and I've not met anyone lately
who expects the default from their laptop to be "stay awake with the
lid shut."
* Save chip bugs that we should add workarounds for, we should be OK
to enter lower sleep states when idling. Flipping this may expose some
further crazy driver, platform or timer bugs, but they again likely
should be fixed.

what do people think?


-a


Index: etc/defaults/rc.conf
===================================================================
--- etc/defaults/rc.conf (revision 265255)
+++ etc/defaults/rc.conf (working copy)
@@ -642,9 +642,9 @@
 devfs_set_rulesets="" # A list of /mount/dev=ruleset_name settings to
  # apply (must be mounted already, i.e. fstab(5))
 devfs_load_rulesets="YES" # Enable to always load the default rulesets
-performance_cx_lowest="HIGH" # Online CPU idle state
+performance_cx_lowest="Cmax" # Online CPU idle state
 performance_cpu_freq="NONE" # Online CPU frequency
-economy_cx_lowest="HIGH" # Offline CPU idle state
+economy_cx_lowest="Cmax" # Offline CPU idle state
 economy_cpu_freq="NONE" # Offline CPU frequency
 virecover_enable="YES" # Perform housekeeping for the vi(1) editor
 ugidfw_enable="NO" # Load mac_bsdextended(4) rules on boot
Index: sys/dev/acpica/acpi.c
===================================================================
--- sys/dev/acpica/acpi.c (revision 265255)
+++ sys/dev/acpica/acpi.c (working copy)
@@ -620,11 +620,12 @@

     /*
      * Dispatch the default sleep state to devices.  The lid switch is set
-     * to UNKNOWN by default to avoid surprising users.
+     * to S3 to mirror what everything else iBook and later does.
      */
     sc->acpi_power_button_sx = acpi_sleep_states[ACPI_STATE_S5] ?
  ACPI_STATE_S5 : ACPI_STATE_UNKNOWN;
-    sc->acpi_lid_switch_sx = ACPI_STATE_UNKNOWN;
+    sc->acpi_lid_switch_sx = acpi_sleep_states[ACPI_STATE_S3] ?
+        ACPI_STATE_S3 : ACPI_STATE_UNKNOWN;
     sc->acpi_standby_sx = acpi_sleep_states[ACPI_STATE_S1] ?
  ACPI_STATE_S1 : ACPI_STATE_UNKNOWN;
     sc->acpi_suspend_sx = acpi_sleep_states[ACPI_STATE_S3] ?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=mUtpjgVwNHg8af05vCxVchZdsaekR9_Wf-pOfFjnABQ>