From owner-svn-src-head@freebsd.org Tue Jan 3 00:45:30 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD3DDC9B620 for ; Tue, 3 Jan 2017 00:45:30 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm7-vm0.bullet.mail.ne1.yahoo.com (nm7-vm0.bullet.mail.ne1.yahoo.com [98.138.91.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 80ACE1CB9 for ; Tue, 3 Jan 2017 00:45:30 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1483403986; bh=Dandy6Z8LhjLcHJEy/t6uHfpB8Bcn00qJc3DygJ9/0c=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=lrw9Mo1rkUJ/dqS3WRz2D66DCLaH3gIdFYmFqJXje6vRsdiTCtFA3+qoxitIAiJKgrh1klsffawjkhgy2mBTv93AYUftd6IWQj0Me9GSAJXkzNtvaOBuVj68uI7emj6RGpmxruG2HXZsiHMi2E+C6acJnfJdk8mLKS8dTc9+VBvbDtRIwI6viaVR5xRF8B9tZLLfvOj4xY3lUWraNYd7RlCAVOEz1/WVb9MuKjeHC6iUhSwPYX2Q3D5bYUkfrZzcT1zAEuG3XT0dhCzNZEHiZoiZyMomQzAq3gypgwLEnTPjgLIbrBZJEbFKSodvhAsMB9fV7YiyDA4C0Pr8JuLBFQ== Received: from [98.138.100.102] by nm7.bullet.mail.ne1.yahoo.com with NNFMP; 03 Jan 2017 00:39:46 -0000 Received: from [98.138.226.30] by tm101.bullet.mail.ne1.yahoo.com with NNFMP; 03 Jan 2017 00:39:46 -0000 Received: from [127.0.0.1] by smtp201.mail.ne1.yahoo.com with NNFMP; 03 Jan 2017 00:39:46 -0000 X-Yahoo-Newman-Id: 299529.20774.bm@smtp201.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: KMkfsoMVM1l7.VBwPaAqKAnreKJ.Hd9DfHk4lamHHaGjlEE cexnM8pXHuHZT3w7jSz1s650rQqiRr2k3uvW14_5ImOJbF7aTmFEqL8nc9Rw byp8zSlsTyHP4q1NMfQ_dB8_ZxQjpg2.86l3En2EJF_Bjiay17SQRq1MpgH2 sI2p6sg3Vtnp2TZbTEbpoZ4cGAeDA1JrxMkOBGueK1bm_M046G42INTnGgHX hVCdBDXc954cxGZepMjySUmhfBGmgZlmsbr6tGd3tBx4rnrkR.IIE3JJnpyg Zsn6QBCJ0EwgkHG.2KY40yysE4oXDkUg.ADKlG.0.cTOHniL0g.MSDEnn6Uz lpJ3iZYNKbCz.5BjQTxcch4vuLny0S7g1aDTGRxLuEovXVq3RksrcLXyj1Fk z0.dfziIpeW6v_Bl8xaL14h8_WCxqZ981qCQetO51wQ1n_iaBbCVYRqrjeUY 6M1.68aT_TknoZ3ykxIg3PKTcsL4sApmUxSANkOEji8Z0AceZ4mxSs7pXB9c tgeIjuQ4i2_xiwmpGCaEcyNMnRtDWxj3EMZiSia9.TJ_ylTg- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r311109 - head/usr.bin/patch To: Conrad Meyer References: <201701021823.v02INWXc028047@repo.freebsd.org> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org> Date: Mon, 2 Jan 2017 19:41:26 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 00:45:30 -0000 On 01/02/17 17:54, Conrad Meyer wrote: > I was suggesting using UINT32_MAX/2 on all platforms (which is safe > everywhere). > Ah OK. INT_MAX is ~ (UINT_MAX / 2) so it's the same to use either. I just think it's clearer to use INT_MAX and the corresponding int type. The other issue is if diff(1) can handle such lines(?). Pedro. > Best, > Conrad > > On Mon, Jan 2, 2017 at 11:48 AM Pedro Giffuni > wrote: > > Hi; > > > > On 01/02/17 13:28, Conrad Meyer wrote: > > > IMO this patch was mostly fine, you just need to restrict line length > > > to UINT32_MAX/2 instead of UINT_MAX (== UINT32_MAX) for 32-bit > > > platforms. > > > > > > Best, > > > Conrad > > > > > > > I dislike the idea of special cases for some platforms. I guess moving > > to int/INT_MAX would be the way to go. > > > > TBH, no one has asked for patches wider than USHRT_MAX though. > > > > Pedro. >