From owner-svn-src-head@freebsd.org  Sun Nov  1 17:20:19 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00B6CA23718;
 Sun,  1 Nov 2015 17:20:19 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BC53B157A;
 Sun,  1 Nov 2015 17:20:18 +0000 (UTC) (envelope-from kp@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id tA1HKHxR060776;
 Sun, 1 Nov 2015 17:20:17 GMT (envelope-from kp@FreeBSD.org)
Received: (from kp@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id tA1HKHLH060775;
 Sun, 1 Nov 2015 17:20:17 GMT (envelope-from kp@FreeBSD.org)
Message-Id: <201511011720.tA1HKHLH060775@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: kp set sender to kp@FreeBSD.org
 using -f
From: Kristof Provost <kp@FreeBSD.org>
Date: Sun, 1 Nov 2015 17:20:17 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r290236 - head/sbin/pfctl
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Nov 2015 17:20:19 -0000

Author: kp
Date: Sun Nov  1 17:20:17 2015
New Revision: 290236
URL: https://svnweb.freebsd.org/changeset/base/290236

Log:
  pfctl: Fix uninitialised veriable
  
  In pfctl_set_debug() we used 'level' without ever initialising it.
  We correctly parsed the option, but them failed to actually assign the parsed
  value to 'level' before performing to ioctl() to configure the debug level.
  
  PR:		202996
  Submitted by:	Andrej Kolontai

Modified:
  head/sbin/pfctl/pfctl.c

Modified: head/sbin/pfctl/pfctl.c
==============================================================================
--- head/sbin/pfctl/pfctl.c	Sun Nov  1 16:59:28 2015	(r290235)
+++ head/sbin/pfctl/pfctl.c	Sun Nov  1 17:20:17 2015	(r290236)
@@ -1840,6 +1840,7 @@ pfctl_set_debug(struct pfctl *pf, char *
 	}
 
 	pf->debug_set = 1;
+	level = pf->debug;
 
 	if ((pf->opts & PF_OPT_NOACTION) == 0)
 		if (ioctl(dev, DIOCSETDEBUG, &level))