From owner-freebsd-net@FreeBSD.ORG  Thu Nov 29 20:39:02 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 7AAAA45A
 for <freebsd-net@freebsd.org>; Thu, 29 Nov 2012 20:39:02 +0000 (UTC)
 (envelope-from bzeeb-lists@lists.zabbadoz.net)
Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25])
 by mx1.freebsd.org (Postfix) with ESMTP id 01BE38FC08
 for <freebsd-net@freebsd.org>; Thu, 29 Nov 2012 20:39:01 +0000 (UTC)
Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.sbone.de (Postfix) with ESMTPS id D5DAC25D3A05;
 Thu, 29 Nov 2012 20:39:00 +0000 (UTC)
Received: from content-filter.sbone.de (content-filter.sbone.de
 [IPv6:fde9:577b:c1a9:31::2013:2742])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mail.sbone.de (Postfix) with ESMTPS id C68AEBE85B6;
 Thu, 29 Nov 2012 20:38:59 +0000 (UTC)
X-Virus-Scanned: amavisd-new at sbone.de
Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587])
 by content-filter.sbone.de (content-filter.sbone.de
 [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024)
 with ESMTP id gPZf-K1EdlEL; Thu, 29 Nov 2012 20:38:58 +0000 (UTC)
Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mail.sbone.de (Postfix) with ESMTPSA id 0DEA3BE85A9;
 Thu, 29 Nov 2012 20:38:57 +0000 (UTC)
Date: Thu, 29 Nov 2012 20:38:57 +0000 (UTC)
From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To: Vijay Singh <vijju.singh@gmail.com>
Subject: Re: A small patch for sys/netinet6/in6_src.c
In-Reply-To: <CALCNsJTR+-HfZhZ8kNxEnm0x9v5XgzBkwqJ4OfBv_gvGsSiHew@mail.gmail.com>
Message-ID: <alpine.BSF.2.00.1211292019480.4401@ai.fobar.qr>
References: <CALCNsJTR+-HfZhZ8kNxEnm0x9v5XgzBkwqJ4OfBv_gvGsSiHew@mail.gmail.com>
X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: freebsd-net@freebsd.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Nov 2012 20:39:02 -0000

On Sun, 25 Nov 2012, Vijay Singh wrote:

> Really trivial change.

Yeah, my comment is probably telling; I was wondering about the
history of the code and why it ended up like that but probably haven't
looked it up but added the XXX-BZ.  I shall handle this.


> /u/vijay/bsd/CODE/cur# svn diff sys/netinet6/in6_src.c
> Index: sys/netinet6/in6_src.c
> ===================================================================
> --- sys/netinet6/in6_src.c	(revision 243309)
> +++ sys/netinet6/in6_src.c	(working copy)
> @@ -597,11 +597,6 @@
> 		if (ron->ro_rt == NULL) {
> 			in6_rtalloc(ron, fibnum); /* multi path case? */
> 			if (ron->ro_rt == NULL) {
> -				/* XXX-BZ WT.? */
> -				if (ron->ro_rt) {
> -					RTFREE(ron->ro_rt);
> -					ron->ro_rt = NULL;
> -				}
> 				error = EHOSTUNREACH;
> 				goto done;
> 			}
> _______________________________________________
> freebsd-net@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-net
> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
>

-- 
Bjoern A. Zeeb                                 You have to have visions!
          Stop bit received. Insert coin for new address family.