From owner-svn-src-head@freebsd.org  Sun Nov  5 17:30:38 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BFB23E4BCFD;
 Sun,  5 Nov 2017 17:30:38 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 46F4633D0;
 Sun,  5 Nov 2017 17:30:38 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kib@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id vA5HUX8A053128
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Sun, 5 Nov 2017 19:30:33 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua vA5HUX8A053128
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id vA5HUXZj053127;
 Sun, 5 Nov 2017 19:30:33 +0200 (EET)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Sun, 5 Nov 2017 19:30:32 +0200
From: Konstantin Belousov <kostikbel@gmail.com>
To: Conrad Meyer <cem@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r325386 - head/sys/kern
Message-ID: <20171105173032.GE2566@kib.kiev.ua>
References: <201711041049.vA4AnZUE096709@repo.freebsd.org>
 <CAG6CVpUaXSX26Bc839kn96EXnUjtGyQ3_eNJPhsRB+v6G6gH1Q@mail.gmail.com>
 <20171105130607.GA2566@kib.kiev.ua>
 <CAG6CVpV3SfV8VuNeMJEuN+MSu3424mK=HO_-YW9vRt9HEdcJZQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG6CVpV3SfV8VuNeMJEuN+MSu3424mK=HO_-YW9vRt9HEdcJZQ@mail.gmail.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Nov 2017 17:30:38 -0000

On Sun, Nov 05, 2017 at 09:16:28AM -0800, Conrad Meyer wrote:
> On Sun, Nov 5, 2017 at 5:06 AM, Konstantin Belousov <kostikbel@gmail.com> wrote:
> > On Sat, Nov 04, 2017 at 12:04:56PM -0700, Conrad Meyer wrote:
> >> This is a functional change, because MPASS (via KASSERT) is only
> >> enabled on DEBUG kernels.  Ideally we would have a kind of ASSERT that
> >> worked on NODEBUG kernels.
> > Why would we need such thing ?
> >
> > Our conventions are clear: consistency checks are normally done with
> > KASSERT() and enabled for DEBUG (INVARIANTS or harder) configurations.
> > We only leave explicit panics in the production kernels when there
> > continuation of operations is worse then abort, e.g. when UFS detects
> > the metadata corruption.
> 
> An always-on assert construct would be precisely for the latter
> scenario.  Instead, we litter the tree with "if (!invariant) {
> panic(); }."
We do

#ifdef INVARIANTS
if (!condition) panic();
#endif

I do not understand what do you mean by 'instead'.