From owner-freebsd-ports@freebsd.org Thu May 5 21:16:41 2016 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3A86B2EC59 for ; Thu, 5 May 2016 21:16:41 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 96EF81515 for ; Thu, 5 May 2016 21:16:41 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id u45LGTXj055344; Thu, 5 May 2016 14:16:33 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201605052116.u45LGTXj055344@gw.catspoiler.org> Date: Thu, 5 May 2016 14:16:29 -0700 (PDT) From: Don Lewis Subject: Re: PRs ready for commit To: lists@opsec.eu cc: bradleythughes@fastmail.fm, freebsd-ports@freebsd.org In-Reply-To: <20160505133206.GB7010@home.opsec.eu> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 21:16:41 -0000 On 5 May, Kurt Jaeger wrote: > Hi! > > One thing: There are issues with buildlogs attached to PR due > to them blowing up the database of bugzilla. If all is fine, > it's OK to just list the architectures tested. Second best > is putting broken buildlogs on some external site and put the link > in the PR. Third is adding broken buildlogs as attachment 8-} > > Yes, I know, disk space is infinite, but this is real life 8-) For broken builds, I prefer to just include the part of the build log showing the error in the comment. If someone thinks that there is still some info necessary for debug that is missing, I can extract it from the log and add it as another comment. That way the info is easy to access and permanently part of the PR.