From owner-freebsd-hackers Sun Apr 14 16:57:42 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from tinker.exit.com (tinker.exit.com [206.223.0.1]) by hub.freebsd.org (Postfix) with ESMTP id E3EC137B400 for ; Sun, 14 Apr 2002 16:57:33 -0700 (PDT) Received: from realtime.exit.com (realtime [206.223.0.5]) by tinker.exit.com (8.12.2/8.12.2) with ESMTP id g3ENvVcQ053726 for ; Sun, 14 Apr 2002 16:57:31 -0700 (PDT) (envelope-from frank@exit.com) Received: from realtime.exit.com (localhost [127.0.0.1]) by realtime.exit.com (8.12.2/8.12.2) with ESMTP id g3ENvHBa091844 for ; Sun, 14 Apr 2002 16:57:17 -0700 (PDT) (envelope-from frank@realtime.exit.com) Received: (from frank@localhost) by realtime.exit.com (8.12.2/8.12.2/Submit) id g3ENvHFT091843 for hackers@freebsd.org; Sun, 14 Apr 2002 16:57:17 -0700 (PDT) From: Frank Mayhar Message-Id: <200204142357.g3ENvHFT091843@realtime.exit.com> Subject: Minor weirdness in pci/agp_amd.c. To: hackers@freebsd.org Date: Sun, 14 Apr 2002 16:57:17 -0700 (PDT) Reply-To: frank@exit.com Organization: Exit Consulting X-Copyright0: Copyright 2002 Frank Mayhar. All Rights Reserved. X-Copyright1: Permission granted for electronic reproduction as Usenet News or email only. X-Mailer: ELM [version 2.4ME+ PL95a (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I'm working on writing a driver for the ServerWorks AGP support from the Linux driver (sans documentation, SIGH :-(). I've been using the various other drivers as models, particularly the AMD driver, since it seems to be closest in many ways to the ServerWorks architecture. Anyway, I've run into a minor oddity in agp_amd_alloc_gatt(), in pci/agp_amd.c. At lines 120-121: gatt->ag_pdir = vtophys((vm_offset_t) gatt->ag_vdir); gatt->ag_pdir = vtophys(gatt->ag_virtual); Looks like one or the other is redundant? Probably the first, I would guess, if the code actually works as it is. -- Frank Mayhar frank@exit.com http://www.exit.com/ Exit Consulting http://www.gpsclock.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message