From owner-freebsd-bugs@freebsd.org  Thu Jul  2 18:05:41 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8C28993586
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Thu,  2 Jul 2015 18:05:41 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id C63AA1E16
 for <freebsd-bugs@FreeBSD.org>; Thu,  2 Jul 2015 18:05:41 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t62I5fwb015511
 for <freebsd-bugs@FreeBSD.org>; Thu, 2 Jul 2015 18:05:41 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 201204] stable/10 mips build fails in usr.bin/gcore
Date: Thu, 02 Jul 2015 18:05:40 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.1-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: na@rtfm.net
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-201204-8-ilA0VGezlU@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-201204-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-201204-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Jul 2015 18:05:41 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201204

--- Comment #1 from na@rtfm.net ---
Based on a grep for that symbol, I think it's pretty certain that the tiny
patch below is correct. Any chance we can fix this before 10.2-RELEASE?

The complete grep:

./sys/arm/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_ARM)
./sys/ia64/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_IA_64)
./sys/mips/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_MIPS)
./sys/powerpc/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_PPC64)
./sys/powerpc/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_PPC)
./sys/sparc64/include/elf.h:#define    ELF_MACHINE_OK(x)    ((x) == ELF_ARCH)
./sys/x86/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_386 || (x) ==
EM_486)
./sys/x86/include/elf.h:#define    ELF_MACHINE_OK(x) ((x) == EM_X86_64)
./usr.bin/gcore/elfcore.c:    if (!ELF_MACHINE_OK(machine))

And the (obvious?) patch:

Index: sys/mips/include/elf.h
===================================================================
--- sys/mips/include/elf.h    (revision 285049)
+++ sys/mips/include/elf.h    (working copy)
@@ -77,6 +77,8 @@
 #define ELF_ARCH    EM_MIPS
 #define ELF_ARCH32    EM_MIPS

+#define    ELF_MACHINE_OK(x) ((x) == EM_MIPS)
+
 /* Define "machine" characteristics */
 #if __ELF_WORD_SIZE == 32
 #define    ELF_TARG_CLASS    ELFCLASS32

-- 
You are receiving this mail because:
You are the assignee for the bug.