Date: Sat, 21 Dec 2013 17:26:55 GMT From: <ohauer@FreeBSD.org> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/185072: [patch] databases/p5-DBI report full $VERSION string (1.63 -> 1.630) Message-ID: <201312211726.rBLHQtpZ046121@freefall.freebsd.org> Resent-Message-ID: <201312211730.rBLHU0t2046209@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 185072 >Category: ports >Synopsis: [patch] databases/p5-DBI report full $VERSION string (1.63 -> 1.630) >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Dec 21 17:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: ohauer >Release: >Organization: >Environment: >Description: Bugzilla checksetup fails since the module reports only version 1.63 because during `$VERSION = eval $VERSION` the trailing 0 is stripped With the fix version 1.630 is reported. There is already an open PR upstream but it seems the PR is ignored ... https://rt.cpan.org/Public/Bug/Display.html?id=90142 >How-To-Repeat: run checksetup with and without the patch without fix: Checking for DBI (v1.614) found v1.63 ... checksetup failed with fix: Checking for DBI (v1.614) ok: found v1.630 >Fix: --- patch_p5-DBI begins here --- Index: databases/p5-DBI/Makefile =================================================================== --- databases/p5-DBI/Makefile (revision 337155) +++ databases/p5-DBI/Makefile (working copy) @@ -3,6 +3,7 @@ PORTNAME= DBI PORTVERSION= 1.630 +PORTREVISION= 1 CATEGORIES= databases perl5 MASTER_SITES= CPAN PKGNAMEPREFIX= p5- Index: databases/p5-DBI/files/patch-DBI.pm =================================================================== --- databases/p5-DBI/files/patch-DBI.pm (revision 0) +++ databases/p5-DBI/files/patch-DBI.pm (working copy) @@ -0,0 +1,11 @@ +--- ./DBI.pm.orig 2013-12-21 17:41:02.000000000 +0100 ++++ ./DBI.pm 2013-12-21 17:41:31.000000000 +0100 +@@ -12,7 +12,7 @@ + + BEGIN { + our $XS_VERSION = our $VERSION = "1.630"; # ==> ALSO update the version in the pod text below! +-$VERSION = eval $VERSION; ++$VERSION = eval '$VERSION'; + } + + =head1 NAME Property changes on: databases/p5-DBI/files/patch-DBI.pm ___________________________________________________________________ Added: fbsd:nokeywords ## -0,0 +1 ## +yes \ No newline at end of property Added: svn:eol-style ## -0,0 +1 ## +native \ No newline at end of property Added: svn:mime-type ## -0,0 +1 ## +text/plain \ No newline at end of property --- patch_p5-DBI ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201312211726.rBLHQtpZ046121>