From owner-freebsd-arch@FreeBSD.ORG Fri Mar 26 13:37:48 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 302C0106564A; Fri, 26 Mar 2010 13:37:48 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 00E1C8FC0A; Fri, 26 Mar 2010 13:37:48 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id A527446B7F; Fri, 26 Mar 2010 09:37:47 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id A2EF08A021; Fri, 26 Mar 2010 09:37:46 -0400 (EDT) From: John Baldwin To: Alexander Leidinger Date: Fri, 26 Mar 2010 07:50:23 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201003241132.29588.jhb@freebsd.org> <20100325.073736.635700942514937954.imp@bsdimp.com> <20100326101524.15695bisy2324t8g@webmail.leidinger.net> In-Reply-To: <20100326101524.15695bisy2324t8g@webmail.leidinger.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003260750.23159.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 26 Mar 2010 09:37:46 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.7 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org Subject: Re: CTF patch for testing/review X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Mar 2010 13:37:48 -0000 On Friday 26 March 2010 5:15:24 am Alexander Leidinger wrote: > Quoting "M. Warner Losh" (from Thu, 25 Mar 2010 > 07:37:36 -0600 (MDT)): > > > In general, I think this is OK. I'd like to see the revised patch > > before it is committed. > > And here it is: > http://www.Leidinger.net/test/ctf3.diff > > My commit log would be something like this: > ---snip--- > WITH_CTF can now be specified in src.conf (not recommended, there > are some problems with static executables), make.conf (would also > affect ports which do not use GNU make and do not override the > compile targets) or in the kernel config (via "makeoptions > WITH_CTF=yes"). > > Additional (related) changes: > - propagate WITH_CTF to module builds > - do not add -g to the linker flags, it's a noop there anyway > (at least according to the man page of ld) > - do not add -g yo CFLAGS unconditionally > we need to have a look if it is really needed (IMO not) or if there > is a way to add it only when WITH_CTF is used > > Note: don't worry when you see ctfconvert lines appearing in your build, > they are protected with a shell conditional and are not run as long as > you don't have WITH_CTF defined. Hmm, perhaps put an @ on the CTF* lines for now to remove them from make output since they are just noise in the common case? I expect at some point in the future that we will end up reverting this commit once we have working userland dtrace and will store CTF symbols in everything by default at which point the '@' can be removed, but until then I think the extra noise outways the gain. > Reviewed by: imp, jhb, scottl (earlier version) > Discussed on: arch@ > ---snip--- > > If nobody comes up with problems (or wants more time for the review): > I would like to commit this next week. > > Bye, > Alexander. > > -- > We are each only one drop in a great > ocean -- but some of the drops sparkle! > > http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 > http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 > -- John Baldwin