Date: Thu, 5 Jan 2017 11:24:16 -0500 From: Diane Bruce <db@db.net> To: Jan Beich <jbeich@freebsd.org> Cc: db@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r430641 - in head/comms/wsjtx: . files Message-ID: <20170105162416.GA49704@night.db.net> In-Reply-To: <20170105150259.3BD4A50FB@freefall.freebsd.org> References: <201701051440.v05EeAs3029482@repo.freebsd.org> <20170105150259.3BD4A50FB@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 05, 2017 at 03:02:59PM +0000, Jan Beich wrote:
> Diane Bruce <db@FreeBSD.org> writes:
>
> > + libomp.so:devel/openmp
>
> devel/openmp is currently amd64-only, so comms/wsjtx loses i386 support
> by unconditionally depending on it.
Unfortunate but so marked.
> > + include_directories("/usr/lib" "${LOCALBASE}/include")
> > +endif()
...
> Why not add USES=localbase:ldflags instead? Besides, -I/usr/lib is bogus
> while -L/usr/lib is poisonous for lang/gcc*.
typo which had no effect upon build anyway. Corrected just because.
>
> Can you fix svn:mime-type of these files?
psvn went nuts and I had only just noticed and was already fixing when
you sent your email.
Take care.
--
- db@FreeBSD.org db@db.net http://www.db.net/~db
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170105162416.GA49704>