From owner-freebsd-current Sun Dec 30 5:52:40 2001 Delivered-To: freebsd-current@freebsd.org Received: from axl.seasidesoftware.co.za (axl.seasidesoftware.co.za [196.31.7.201]) by hub.freebsd.org (Postfix) with ESMTP id 8263C37B419; Sun, 30 Dec 2001 05:52:33 -0800 (PST) Received: from sheldonh (helo=axl.seasidesoftware.co.za) by axl.seasidesoftware.co.za with local-esmtp (Exim 3.33 #1) id 16KgPv-000NPY-00; Sun, 30 Dec 2001 15:54:23 +0200 From: Sheldon Hearn To: Maxim Konovalov Cc: Poul-Henning Kamp , current@FreeBSD.ORG, chad@FreeBSD.ORG Subject: Re: Junior Kernel Hacker Task: ccdinit stack usage. In-reply-to: Your message of "Sun, 30 Dec 2001 16:45:31 +0300." <20011230160821.L36208-100000@news1.macomnet.ru> Date: Sun, 30 Dec 2001 15:54:23 +0200 Message-ID: <89995.1009720463@axl.seasidesoftware.co.za> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 30 Dec 2001 16:45:31 +0300, Maxim Konovalov wrote: > struct partinfo holds only two pointers, ccg is a pointer too. I got confused with partinfo and disklabel, and didn't actually check ccg. *blush* > > Note that you don't need to (and shouldn't as per style(9)) initialize > > tmppath to NULL. > > Do you mean: > > : Be careful to not obfuscate the code by initializing variables > : in the declarations. Use this feature only thoughtfully. DO NOT > : use function calls in initializers. > > or something else? Yes, that. Bruce Evans will probably want tmppath initialized to NULL near the top of the function's code, rather than in the declarations. :-) > man 9 malloc: > > : A type is defined using the malloc_type_t typedef via the > : MALLOC_DECLARE() and MALLOC_DEFINE() macros. > > Take a look at /usr/src/sys/sys/malloc.h. That only tells me where it comes from, not when I'd want to use it. :-) > What about this one: It's probably worth giving Poul-Henning time to wake up. ;-) Ciao, Sheldon. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message