From owner-freebsd-hackers Tue Apr 8 06:10:14 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id GAA07877 for hackers-outgoing; Tue, 8 Apr 1997 06:10:14 -0700 (PDT) Received: from etinc.com (et-gw-fr1.etinc.com [204.141.244.98]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA07872 for ; Tue, 8 Apr 1997 06:10:08 -0700 (PDT) Received: from dbws.etinc.com (db@dbws.etinc.com [204.141.95.130]) by etinc.com (8.8.3/8.6.9) with SMTP id JAA10878; Tue, 8 Apr 1997 09:15:41 -0400 (EDT) Message-Id: <3.0.32.19970408090836.00694a80@etinc.com> X-Sender: dennis@etinc.com X-Mailer: Windows Eudora Pro Version 3.0 (32) Date: Tue, 08 Apr 1997 09:08:38 -0400 To: dg@root.com From: dennis Subject: Re: pci_map_mem reports failure Cc: hackers@FreeBSD.ORG Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk At 05:27 PM 4/7/97 -0700, David Greenman wrote: >Dennis: > >>>I've noticed that pci_map_mem() reports a failure (in the form of a >>>display to the screen) if the PCI memory space is below 1 MB (dos >>>space), but that the function returns OK and a virtual mapping is >>>returned as well. There's a comment (in german) in the source, and >>>my German is rather weak (there seems to be a reference to PCI- >>>PCI bridges) .....is this a real failure, a warning, or does FreeBSD >>>not support PCI memory in the DOS hole (not that you'd actually >>>WANT to put it there...)? > >To which I said: > >> The test for < 1MB should only be for the < 1MB PCI memory type, but >>isn't strictly necessary...I'm not familiar with what the PCI spec has to >>say about it. The function ultimately calls pmap_mapdev() which has no >>trouble mapping any physical address. Actually I'm porting to 2.2.1...... > > It just occured to me that you're probably using 2.1.x, so this bug fix >is probably of interest: > >---------------------------- >revision 1.56 >date: 1996/10/14 13:04:34; author: se; state: Exp; lines: +4 -2 >pci_map_mem() did a too restrictive check on the mapping type: >PCI_MAP_MEMORY_TYPE_32BIT_1M should be accepted as well as >PCI_MAP_MEMORY_TYPE_32BIT (and now is). >(Problem reported by David Greenman.) The error I'm getting is on line 1064 of FreeBSD 2.2.1 pci.c file. Perhaps one of our german readers can translate..... :-) Dennis