From owner-freebsd-python@freebsd.org Sat Sep 14 03:52:56 2019 Return-Path: Delivered-To: freebsd-python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4833BDD679 for ; Sat, 14 Sep 2019 03:52:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 46VdrS1BxPz4S2Y for ; Sat, 14 Sep 2019 03:52:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 291BADD677; Sat, 14 Sep 2019 03:52:56 +0000 (UTC) Delivered-To: python@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 28DDEDD676 for ; Sat, 14 Sep 2019 03:52:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46VdrS0KRgz4S2W for ; Sat, 14 Sep 2019 03:52:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E3B2419FCD for ; Sat, 14 Sep 2019 03:52:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x8E3qtOJ093685 for ; Sat, 14 Sep 2019 03:52:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x8E3qt9a093684 for python@FreeBSD.org; Sat, 14 Sep 2019 03:52:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 240476] security/py-fido2: Add FreeBSD support Date: Sat, 14 Sep 2019 03:52:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature, needs-patch, needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Sep 2019 03:52:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240476 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch --- Comment #15 from Kubilay Kocak --- Thanks Michael, nice work upstreaming.=20 A couple of leftovers: - RUN_DEPENDS don't also need to be in TEST_DEPENDS (uhid-freebsd) - setup.py says uhid-freebsd>=3D1.2.1, RUN_DEPENDS says >=3D1.0. *_DEPENDS = should match upstream requirements as closely as possible modulo any syntax limitations we have (we cant foo!=3Dx.y right now for example) On the test suite with OS specific tests, upstreams should always 'skip' th= ese tests if the environment isn't appropriate for the test. pytest and nose ha= ve very easy decorators upstreams can use to do this with various condition support) When test suites 'dont' skip inappropriate tests, one can usually (with most unittest frameworks), skip individual tests explicitly in the test invocati= on. For example with pytest you can -k 'not ' and with nose you can -e{xclude} With unittest (in Python > 3.1) you can skipIf [1], i cant recall if there'= s a command line arg for skipping tests. Also, if the tests use 'unittest', then the Python package should probably tests_require on "unittest2; python_vers= ion < 3" [1] https://docs.python.org/3/library/unittest.html#unittest.skipIf --=20 You are receiving this mail because: You are the assignee for the bug.=