From owner-freebsd-i386@FreeBSD.ORG  Mon Feb  9 18:20:21 2004
Return-Path: <owner-freebsd-i386@FreeBSD.ORG>
Delivered-To: freebsd-i386@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CF07716A4CF; Mon,  9 Feb 2004 18:20:21 -0800 (PST)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5746F43D1F; Mon,  9 Feb 2004 18:20:21 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])i1A2KJLE013824;	Tue, 10 Feb 2004 13:20:19 +1100
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i1A2KHYc011617;	Tue, 10 Feb 2004 13:20:18 +1100
Date: Tue, 10 Feb 2004 13:20:17 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Radim Kolar <hsn@netmag.cz>
In-Reply-To: <E1ApuXc-0000xL-Bu@asura.bsd>
Message-ID: <20040210131116.U51076@gamplex.bde.org>
References: <E1ApuXc-0000xL-Bu@asura.bsd>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: FreeBSD-gnats-submit@freebsd.org
cc: freebsd-i386@freebsd.org
Subject: Re: i386/62595: npx.c do not compiles without ISA bus configured
X-BeenThere: freebsd-i386@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: I386-specific issues for FreeBSD <freebsd-i386.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-i386>,
	<mailto:freebsd-i386-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-i386>
List-Post: <mailto:freebsd-i386@freebsd.org>
List-Help: <mailto:freebsd-i386-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-i386>,
	<mailto:freebsd-i386-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Feb 2004 02:20:21 -0000

On Sun, 8 Feb 2004, Radim Kolar wrote:

> >Description:
> If you don't have 'device isa' entry in kernel configuration, kernel
> build will fail in npx driver. I want to build a smallest possible kernel,
> so i have commeted isa bus out.

Try this patch.  i386 require isa so leaving it out will give a kernel
hat won't actually work, however.  The NPX_ISA ifdefs in npx.c basically
leave out isa-pnp, not isa, and some i386 kernels configured without isa
can only be linked because not configuring it doesn't actually leave out
all the isa bits.

%%%
Index: npx.c
===================================================================
RCS file: /home/ncvs/src/sys/i386/isa/npx.c,v
retrieving revision 1.144
diff -u -2 -r1.144 npx.c
--- npx.c	3 Nov 2003 21:53:38 -0000	1.144
+++ npx.c	10 Feb 2004 01:30:35 -0000
@@ -1038,5 +1038,4 @@
 static devclass_t npx_devclass;

-#ifdef DEV_ISA
 /*
  * We prefer to attach to the root nexus so that the usual case (exception 16)
@@ -1045,4 +1044,5 @@
 DRIVER_MODULE(npx, nexus, npx_driver, npx_devclass, 0, 0);

+#ifdef DEV_ISA
 /*
  * This sucks up the legacy ISA support assignments from PNPBIOS/ACPI.
%%%

Bruce