From owner-freebsd-commit  Sat Nov 18 04:29:14 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id EAA18533
          for freebsd-commit-outgoing; Sat, 18 Nov 1995 04:29:14 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id EAA18518
          for cvs-all-outgoing; Sat, 18 Nov 1995 04:29:05 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id EAA18502
          for cvs-sys-outgoing; Sat, 18 Nov 1995 04:28:58 -0800
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id EAA18487
          ; Sat, 18 Nov 1995 04:28:29 -0800
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id XAA23409; Sat, 18 Nov 1995 23:27:45 +1100
Date: Sat, 18 Nov 1995 23:27:45 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199511181227.XAA23409@godzilla.zeta.org.au>
To: bde@freefall.freebsd.org, j@uriah.heep.sax.de
Subject: Re: cvs commit: src/sys/i386/isa isa.h
Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org
Sender: owner-commit@FreeBSD.ORG
Precedence: bulk

>>   Modified:    sys/i386/isa  isa.h
>>   Log:
>>   Updated comments.  The comments about the unused addresses get broken
>>   almost every time someone uses an address.  This file is probably not
>>   the right place to keep track of the unused addresses (or used
>>   addresses :->).

>Updated... Fixed... perhaps it's also time to finally move out the
>timer base frequency #define into isa.h now?  (The various definitions
>could perhaps be found by "XXX should be in isa.h". :-)

I didn't know much about the header layout when I wrote the first of
those XXX's.  The frequency should be defined in a clock driver `reg.h'
file (`reg' is a misleading abbreviation for `mapping of the device
registers to i/o or memory and other miscellaneous bus glue).  We
already have two such files with mostly misplaced things in them:

	timerreg.h		for the `clk0' device
	rtc.h			for the `rtc0' device

We should have

	ic/i825[3-4].h		for the clk0 device's ic
	clkreg.h		for the clk0 device's bus glue including
				TIMER_FREQ
	ic/mc146818.h		for the rtc0 device's ic
	rtcreg.h		for the rtc0 device's bus glue (this is
				particularly messy because the device
				registers are multiplexed and some
				firmware (BIOS) conventions are best
				recorded here)

I won't be cleaning this up any time sonn because I'm sick of cleaning
up (and I still have to commit prototype-related changes for about 300
files).

Bruce